Fix various problems with the credits roll #113298
Merged
+54
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Nov 29, 2025
KoBeWi
reviewed
Nov 29, 2025
YeldhamDev
force-pushed
the
teria_sido_melhor_ir_ver_o_filme_do_pele
branch
from
f2f2b18 to
f8c251a
Compare
KoBeWi
approved these changes
Nov 29, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our little credits roll is a cute Easter egg, and works great, as long as you don't mess around with the window while it plays at least. Most of the problems came from it being a
Popup, which this PR fixes by turning it into aCanvasLayer.