[Web] Add "threads"/"nothreads" feature tags to export presets #93556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that makes sense to add. |
This comment was marked as outdated.
This comment was marked as outdated.
|
7 tasks
|
I went ahead and made a PR for a |
|
Can be rebased on top of #93563 to add the Web exporter counterpart. |
Following the "variant/thread_support" preset option.
Faless
force-pushed
the
web/fix_threads_features
branch
from
e805250 to
f59c1f0
Compare
Faless
changed the title
Done |
akien-mga
approved these changes
Jun 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows selecting threads/nothreads gdextensions at export time (see godotengine/godot-cpp#1451).
As per my comment (godotengine/godot-cpp#1451 (comment)) it would be nice to provide also a
nothreadsfeature flag to avoid relying on ordering in thegdextensionfile (and improve detection when using auto prefix).See Faless@a17b075 for the relevant changes (happy to attach them to this PR).