[Day 24] Small improvements

Author: goggle

README.md

@@ -32,7 +32,7 @@ This Julia package contains my solutions for [Advent of Code 2024](https://adven
 | 20 | [:white_check_mark:](https://adventofcode.com/2024/day/20) | 227.453 ms | 224.97 MiB| [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day20.jl) |
 | 22 | [:white_check_mark:](https://adventofcode.com/2024/day/22) | 241.724 ms | 78.80 MiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day22.jl) |
 | 23 | [:white_check_mark:](https://adventofcode.com/2024/day/23) | 4.197 ms | 3.82 MiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day23.jl) |
-| 24 | [:white_check_mark:](https://adventofcode.com/2024/day/24) | 9.476 s | 4.84 GiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day24.jl) |
+| 24 | [:white_check_mark:](https://adventofcode.com/2024/day/24) | 8.618 s | 4.84 GiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day24.jl) |
 <!-- | 21 | [:white_check_mark:](https://adventofcode.com/2024/day/21) | 9.675 ms | 7.19 MiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day21.jl) | -->
 <!-- | 25 | [:white_check_mark:](https://adventofcode.com/2024/day/25) | 69.476 ms | 62.03 MiB | [:white_check_mark:](https://github.com/goggle/AdventOfCode2024.jl/blob/main/src/day25.jl) | -->
 

src/day24.jl

@@ -4,10 +4,10 @@ using AdventOfCode2024
 
 function day24(input::String = readInput(joinpath(@__DIR__, "..", "data", "day24.txt")))
     x, y, rules = parse_input(input)
-    p1, _ = run(x, y, rules, nothing)
+    p1, ruleorder = run(x, y, rules, nothing)
 
     swapped_outputs = []
-    _, wrong_adders = check_adders(rules, Int[])
+    wrong_adders = [i for i ∈ 0:44 if !check_adders_at_indices(rules, [i]; ruleorder)[1]]
 
     sequences = find_sequences(wrong_adders)
     for sequence ∈ sequences
@@ -91,7 +91,7 @@ function parse_input(input::AbstractString)
     return x, y, rule
 end
 
-function run(x::Int, y::Int, rules::Vector{NTuple{4, String}}, ruleorder::Nothing)
+function run(x::Int, y::Int, rules::Vector{NTuple{4, String}}, _::Nothing)
     state = Dict{String,Bool}()
     unused_rules = Set(1:length(rules))
     prev_length = length(unused_rules) + 1
@@ -196,8 +196,6 @@ function run(x::Int, y::Int, rules::Vector{NTuple{4, String}}, ruleorder::Vector
     return result, ruleorder
 end
 
-
-
 function needed_rules(rules::Vector{NTuple{4, String}}, outinds::Vector{Int})
     ruleinds = Set{Int}()
     reg = r"[xy]\d{2}"
@@ -216,27 +214,6 @@ function needed_rules(rules::Vector{NTuple{4, String}}, outinds::Vector{Int})
     return ruleinds
 end
 
-function check_adders(rules::Vector{NTuple{4, String}}, ignore_indices::Vector{Int}; ruleorder::Union{Vector{Int},Nothing} = nothing)
-    wrong = Int[]
-    xi = (0, 0, 1, 1, 0, 1, 0, 1)
-    yi = (0, 1, 0, 1, 0, 0, 1, 1)
-    cprev = (0, 0, 0, 0, 1, 1, 1, 1)
-    for index ∈ setdiff(0:44, ignore_indices)
-        iter = index == 0 ? (1:4) : (1:8)
-        for i ∈ iter
-            x = (xi[i] << index) + (cprev[i] << (index - 1))
-            y = (yi[i] << index) + (cprev[i] << (index - 1))
-            result, ruleorder = run(x, y, rules, ruleorder)
-            result == -1 && return false, wrong
-            if result != x + y
-                push!(wrong, index)
-                break
-            end
-        end
-    end
-    return true, wrong
-end
-
 function check_adders_at_indices(rules::Vector{NTuple{4, String}}, indices::Vector{Int}; ruleorder::Union{Vector{Int},Nothing} = nothing)
     xi = (0, 0, 1, 1, 0, 1, 0, 1)
     yi = (0, 1, 0, 1, 0, 0, 1, 1)