Skip to content

Add condition to disable nginx even if not exposing via ingress #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add condition to disable nginx even if not exposing via ingress #1687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
146e797
add condition to disable deployment of nginx even if you do not expos…
rgarcia89 Jan 19, 2024
3833764
update readme
rgarcia89 Jan 22, 2024
893345e
implemented Vadims #1073 PR changes
rgarcia89 Jan 22, 2024
0b1bef8
fix markdown
rgarcia89 Jan 22, 2024
e90f2fe
readme markdown foo
rgarcia89 Jan 22, 2024
439260e
revert changes in nginx changes
rgarcia89 Jan 22, 2024
3800c79
markdown next try
rgarcia89 Jan 22, 2024
4e4c994
resolve conflicting files
rgarcia89 Oct 8, 2024
b7c1b17
Merge branch 'main' into nginx
rgarcia89 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/nginx/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if ne .Values.expose.type "ingress" }}
{{- if and (ne .Values.expose.type "ingress") .Values.nginx.enabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
3 changes: 2 additions & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,9 @@ enableMigrateHelmHook: false
# contains a base64 encoded CA Certificate named `ca.crt`.
# uaaSecretName:

# If service exposed via "ingress", the Nginx will not be used
# If service exposed via "ingress", or not enabled the Nginx will not be used
nginx:
enabled: true
image:
repository: goharbor/nginx-photon
tag: dev
Expand Down