-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: Add clarifying comments to harbor.yml.tpl #22128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c10f746
to
ebb8323
Compare
ebb8323
to
19695c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main goharbor/harbor#22128 +/- ##
===========================================
+ Coverage 45.36% 68.56% +23.19%
===========================================
Files 244 819 +575
Lines 13333 101462 +88129
Branches 2719 0 -2719
===========================================
+ Hits 6049 69569 +63520
- Misses 6983 28019 +21036
- Partials 301 3874 +3573
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
make/harbor.yml.tmpl
Outdated
# (e.g., Docker CLI, web browsers) support modern TLS 1.2+ ciphers to avoid connection issues. | ||
# enable strong ssl ciphers (default: false) | ||
# strong_ssl_ciphers: false | ||
strong_ssl_ciphers: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you improving the docs or changing the logic?
It seems like you changed from false to true # enable strong ssl ciphers (default: false)
I suggest only doing one thing in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will rectify the logic part and let this PR only focus on adding comments. Thanks for notifying
1cd8c76
to
94ca49c
Compare
Signed-off-by: chethanm99 <chethanm1399@gmail.com>
94ca49c
to
8e01678
Compare
@Vad1mo I've made changes , please let me know if any other changes to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be an overkill. the things are pretty self explanatory already IMO.
@bupd I understand your point, since you are telling that this change isn't necessary and wouldn't help much, let me just go ahead and close this PR. Thanks for your time ! |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes goharbor/website#666
This PR fixes the issue and improves the user experience the other file changes related to this PR is here : goharbor/website#658
Please indicate you've done the following: