-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: add regex filter for replication #22162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: TMHBOFH <itsystem.bofh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing consistency,regex should be allowed in name and tag.
There is also an older PR that does the same thing.
#18723
Also a community proposal: goharbor/community#221
I suggest building upon previous work.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22162 +/- ##
===========================================
+ Coverage 45.36% 65.87% +20.50%
===========================================
Files 244 1072 +828
Lines 13333 115726 +102393
Branches 2719 2925 +206
===========================================
+ Hits 6049 76230 +70181
- Misses 6983 35268 +28285
- Partials 301 4228 +3927
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
I’ll take a look at that. The name is handled using the same function ( A response to my other PR22017 would be much appreciated, as the functionality is important for us. Thank you. |
We are approaching v2.14 feature complete and this enhancement will need to target for later releases. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
This change enhances the tag and repository filtering logic by enabling support for regular expressions for replication. Users can now specify filters using the
regex:
prefix, allowing for more flexible and powerful matching patterns. For example, patterns likeregex:^1\.(34\..*|32\.(4|5|6))$
can be used to match specific version formats.Screenshots
Please indicate you've done the following: