-
Notifications
You must be signed in to change notification settings - Fork 5k
Arm64 Official Support #22229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm64 Official Support #22229
Conversation
…tions Signed-off-by: Ubuntu <ubuntu@ip-172-31-100-229.ec2.internal>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22229 +/- ##
===========================================
+ Coverage 45.36% 65.90% +20.53%
===========================================
Files 244 1072 +828
Lines 13333 115862 +102529
Branches 2719 2925 +206
===========================================
+ Hits 6049 76357 +70308
- Misses 6983 35277 +28294
- Partials 301 4228 +3927
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds official ARM64 architecture support to Harbor, enabling it to run natively on both ARM64 and AMD64 platforms. The changes implement platform detection and conditional build configurations to support multi-architecture deployments.
Key changes:
- Platform detection and platform-specific container configurations in Docker Compose templates
- Architecture-specific dependency versions and build parameters in Makefiles
- Conditional PostgreSQL package installation based on target architecture
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
make/photon/prepare/utils/docker_compose.py | Adds platform detection logic to set appropriate Docker platform for containers |
make/photon/prepare/templates/docker_compose/docker-compose.yml.jinja | Updates Docker Compose template to include platform specification for all services |
make/photon/db/Dockerfile.base | Implements conditional PostgreSQL package installation based on target architecture |
make/photon/Makefile | Adds platform detection and applies platform-specific build parameters |
Makefile | Introduces architecture-specific dependency versions and download URLs |
Comments suppressed due to low confidence (1)
Makefile:135
- The ARM64 Trivy version v0.58.2 appears to be older than the AMD64 version v0.61.0. Verify that v0.58.2 exists and is the correct version to use for ARM64, or consider using a more recent version if available.
TRIVY_DOWNLOAD_URL=https://github.com/aquasecurity/trivy/releases/download/$(TRIVYVERSION)/trivy_$(TRIVYVERSION)_Linux-ARM64.tar.gz
I am facing an issue while trying to build using your fork and branch.
EDIT: |
Tested and confirmed: Harbor functions fully on both Arm64 and Amd64 platforms, including the UI, API, registry, and multi-architecture artifact handling.
Commands:
Building locally (Harbor components and base images)
These steps will:
• Build Harbor entirely from source
• Use your own locally built base images
• Run natively on Arm64/AMD64
Open for suggestions !! Closes #21982