Remove unnecessary byte slice arg from TestMigrate() in database/testing

dhui · dhui · commit 4e593fd2a9dd · 2020-01-03T00:15:52.000-08:00
diff --git a/database/cassandra/cassandra_test.go b/database/cassandra/cassandra_test.go
@@ -101,6 +101,6 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT table_name from system_schema.tables"))
+		dt.TestMigrate(t, m)
 	})
 }
diff --git a/database/cockroachdb/cockroachdb_test.go b/database/cockroachdb/cockroachdb_test.go
@@ -121,7 +121,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT 1"))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/firebird/firebird_test.go b/database/firebird/firebird_test.go
@@ -121,7 +121,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT Count(*) FROM rdb$relations"))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/mongodb/mongodb_test.go b/database/mongodb/mongodb_test.go
@@ -121,7 +121,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte(`[{"insert":"hello","documents":[{"wild":"world"}]}]`))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/mysql/mysql_test.go b/database/mysql/mysql_test.go
@@ -124,7 +124,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT 1"))
+		dt.TestMigrate(t, m)
 
 		// check ensureVersionTable
 		if err := d.(*Mysql).ensureVersionTable(); err != nil {
diff --git a/database/postgres/postgres_test.go b/database/postgres/postgres_test.go
@@ -111,7 +111,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT 1"))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/ql/ql_test.go b/database/ql/ql_test.go
@@ -77,5 +77,5 @@ func TestMigrate(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	dt.TestMigrate(t, m, []byte("CREATE TABLE t (Qty int, Name string);"))
+	dt.TestMigrate(t, m)
 }
diff --git a/database/redshift/redshift_test.go b/database/redshift/redshift_test.go
@@ -118,7 +118,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT 1"))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/spanner/spanner_test.go b/database/spanner/spanner_test.go
@@ -55,7 +55,7 @@ func TestMigrate(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	dt.TestMigrate(t, m, []byte("SELECT 1"))
+	dt.TestMigrate(t, m)
 }
 
 func TestMultistatementSplit(t *testing.T) {
diff --git a/database/sqlite3/sqlite3_test.go b/database/sqlite3/sqlite3_test.go
@@ -66,7 +66,7 @@ func TestMigrate(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	dt.TestMigrate(t, m, []byte("CREATE TABLE t (Qty int, Name string);"))
+	dt.TestMigrate(t, m)
 }
 
 func TestMigrationTable(t *testing.T) {
diff --git a/database/sqlserver/sqlserver_test.go b/database/sqlserver/sqlserver_test.go
@@ -114,7 +114,7 @@ func TestMigrate(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		dt.TestMigrate(t, m, []byte("SELECT 1"))
+		dt.TestMigrate(t, m)
 	})
 }
 
diff --git a/database/stub/stub_test.go b/database/stub/stub_test.go
@@ -39,5 +39,5 @@ func TestMigrate(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	dt.TestMigrate(t, m, []byte("/* foobar migration */"))
+	dt.TestMigrate(t, m)
 }
diff --git a/database/testing/migrate_testing.go b/database/testing/migrate_testing.go
@@ -12,12 +12,7 @@ import (
 )
 
 // TestMigrate runs integration-tests between the Migrate layer and database implementations.
-//
-func TestMigrate(t *testing.T, m *migrate.Migrate, migration []byte) {
-	if migration == nil {
-		panic("test must provide migration reader")
-	}
-
+func TestMigrate(t *testing.T, m *migrate.Migrate) {
 	TestMigrateUp(t, m)
 	TestMigrateDrop(t, m)
 }

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,6 @@ func TestMigrate(t *testing.T) {`
`101`	`101`	`if err != nil {`
`102`	`102`	`t.Fatal(err)`
`103`	`103`	`}`
`104`		`- dt.TestMigrate(t, m, []byte("SELECT table_name from system_schema.tables"))`
	`104`	`+ dt.TestMigrate(t, m)`
`105`	`105`	`})`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func TestMigrate(t *testing.T) {`
`121`	`121`	`if err != nil {`
`122`	`122`	`t.Fatal(err)`
`123`	`123`	`}`
`124`		`- dt.TestMigrate(t, m, []byte("SELECT 1"))`
	`124`	`+ dt.TestMigrate(t, m)`
`125`	`125`	`})`
`126`	`126`	`}`
`127`	`127`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ func TestMigrate(t *testing.T) {`
`124`	`124`	`if err != nil {`
`125`	`125`	`t.Fatal(err)`
`126`	`126`	`}`
`127`		`- dt.TestMigrate(t, m, []byte("SELECT 1"))`
	`127`	`+ dt.TestMigrate(t, m)`
`128`	`128`
`129`	`129`	`// check ensureVersionTable`
`130`	`130`	`if err := d.(*Mysql).ensureVersionTable(); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ func TestMigrate(t *testing.T) {`
`111`	`111`	`if err != nil {`
`112`	`112`	`t.Fatal(err)`
`113`	`113`	`}`
`114`		`- dt.TestMigrate(t, m, []byte("SELECT 1"))`
	`114`	`+ dt.TestMigrate(t, m)`
`115`	`115`	`})`
`116`	`116`	`}`
`117`	`117`
Original file line number	Diff line number	Diff line change
`@@ -77,5 +77,5 @@ func TestMigrate(t *testing.T) {`
`77`	`77`	`if err != nil {`
`78`	`78`	`t.Fatal(err)`
`79`	`79`	`}`
`80`		`- dt.TestMigrate(t, m, []byte("CREATE TABLE t (Qty int, Name string);"))`
	`80`	`+ dt.TestMigrate(t, m)`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ func TestMigrate(t *testing.T) {`
`118`	`118`	`if err != nil {`
`119`	`119`	`t.Fatal(err)`
`120`	`120`	`}`
`121`		`- dt.TestMigrate(t, m, []byte("SELECT 1"))`
	`121`	`+ dt.TestMigrate(t, m)`
`122`	`122`	`})`
`123`	`123`	`}`
`124`	`124`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func TestMigrate(t *testing.T) {`
`55`	`55`	`if err != nil {`
`56`	`56`	`t.Fatal(err)`
`57`	`57`	`}`
`58`		`- dt.TestMigrate(t, m, []byte("SELECT 1"))`
	`58`	`+ dt.TestMigrate(t, m)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`func TestMultistatementSplit(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func TestMigrate(t *testing.T) {`
`66`	`66`	`if err != nil {`
`67`	`67`	`t.Fatal(err)`
`68`	`68`	`}`
`69`		`- dt.TestMigrate(t, m, []byte("CREATE TABLE t (Qty int, Name string);"))`
	`69`	`+ dt.TestMigrate(t, m)`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`func TestMigrationTable(t *testing.T) {`