Skip to content

Commit bd65f44

Browse files
h9jianggopherbot
authored andcommitted
docs/contributing.md: update the link to help wanted git issue
- The label selector using "help wanted" lead to a page without any issue. - TSLint extension is now deprecated in favor of ESLint. Change-Id: Iea0cd033d840e24e8c4c4e00c5e05a9989e282d2 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/617975 Auto-Submit: Hongxiang Jiang <hxjiang@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Commit-Queue: Hongxiang Jiang <hxjiang@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com>
1 parent 825de6b commit bd65f44

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/contributing.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Our canonical Git repository is located at https://go.googlesource.com/vscode-go
2121

2222
If you are interested in fixing a bug or contributing a feature, please [file an issue](https://github.com/golang/vscode-go/issues/new/choose) first. Wait for a project maintainer to respond before you spend time coding.
2323

24-
If you wish to work on an existing issue, please add a comment saying so, as someone may already be working on it. A project maintainer may respond with advice on how to get started. If you're not sure which issues are available, search for issues with the [help wanted label](https://github.com/golang/vscode-go/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22).
24+
If you wish to work on an existing issue, please add a comment saying so, as someone may already be working on it. A project maintainer may respond with advice on how to get started. If you're not sure which issues are available, search for issues with the [help wanted label](https://github.com/golang/vscode-go/labels/HelpWanted).
2525

2626
### Ask for help
2727

@@ -38,7 +38,7 @@ For extending the language features or fixing bugs, please follow `gopls`'s
3838

3939
### Debug Adapter (`dlv dap`)
4040

41-
Debugging features are implemented by Delve (`dlv`) and its native DAP implementation
41+
Debugging features are implemented by Delve (`dlv`) and its native DAP implementation
4242
([`dlv dap`](https://github.com/go-delve/delve/blob/master/Documentation/api/dap/README.md)).
4343

4444
* goDebugConfiguration.ts: where launch configuration massaging occurs.
@@ -65,7 +65,7 @@ The debugging feature documentation has a dedicated section for tips for develop
6565

6666
#### Lint
6767

68-
You can run `npm run lint` on the command-line to check for lint errors in your program. You can also use the [TSLint](https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin) plugin to see errors as you code.
68+
You can run `npm run lint` on the command-line to check for lint errors in your program. You can also use the [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) plugin to see errors as you code.
6969

7070
### Run
7171

@@ -96,7 +96,7 @@ When running them from terminal:
9696
- Option 1: Utilize `MOCHA_GREP` environment variable. That is equivalent with [`mocha --grep` flag](https://mochajs.org/#command-line-usage) that runs tests matching the given string or regexp. E.g. `MOCHA_GREP=gopls npm run test` which runs all integration tests whose suite/test names contain `"gopls"`.
9797
- Option 2: modify the test source code and set the [`only`](https://mochajs.org/#exclusive-tests) or [`skip`](https://mochajs.org/#inclusive-tests) depending on your need. If necessary, you can also modify `test/integration/index.ts` or `test/gopls/index.ts` to include only the test files you want to focus on. Make sure to revert them before sending the changes for review.
9898
99-
#### (2) Debugging tests from VS Code:
99+
#### (2) Debugging tests from VS Code:
100100
`.vscode/launch.json` defines test launch configurations. To run the tests locally, open the Run view (`Ctrl+Shift+D`), select the relevant launch configuration, and hit the Play button (`F5`). Output and results of the tests, including any logging written with `console.log` will appear in the `DEBUG CONSOLE` tab.
101101
You can supply environment variables (e.g. `MOCHA_GREP`) by modifying the launch configuration entry's `env` property.
102102
- `Launch Unit Tests`: runs unit tests in `test/unit` (same as `npm run unit-test`)
@@ -183,7 +183,7 @@ Once you've sent out your change, a maintainer will take a look at your contribu
183183
### Presubmit Test in CI
184184
185185
When you mail your CL or upload a new patch to an existing CL, *AND*
186-
you or a fellow contributor assigns the `Run-TryBot=+1` label in Gerrit, the test command defined in
186+
you or a fellow contributor assigns the `Run-TryBot=+1` label in Gerrit, the test command defined in
187187
`build/all.bash` will run by `Kokoro`, which is Jenkins-like Google infrastructure
188188
for running Dockerized tests. `Kokoro` will post the result as a comment, and add its `TryBot-Result`
189189
vote after each test run completes.

0 commit comments

Comments
 (0)