Skip to content

Conversation

@rao107
Copy link
Contributor

@rao107 rao107 commented Sep 7, 2025

Copy link
Collaborator

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, especially doing all of the statements on the page.

I left a few initial comments, but looks good in general..

Comment on lines 40 to 41
theorem erdos_503 {n : ℕ} : ∃ A : Set (ESpace n), isoscelesSet A ∧ (∀ B : Set (ESpace n),
isoscelesSet B → B.ncard ≤ A.ncard) ∧ A.ncard = answer(sorry) := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one could use IsGreatest here
also below.
But perhaps even better define the largest such that separately using iSup or sSup then we can use it all over the place?

@mo271 mo271 added Erdős Problems Awaiting author A reviewer has asked the author a question or requested changes. labels Sep 7, 2025
@rao107
Copy link
Contributor Author

rao107 commented Sep 11, 2025

Apologies for the delay!

I wasn't sure how to best define "largest such that", so I decided to use IsGreatest since that was more straightforward.

@callesonne callesonne removed the Awaiting author A reviewer has asked the author a question or requested changes. label Sep 30, 2025
Copy link
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Here are some comments :)

Copy link
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go after my final comment has been adressed, thanks a lot!

@rao107
Copy link
Contributor Author

rao107 commented Oct 19, 2025

This is ready to go after my final comment has been adressed, thanks a lot!

Fixed now, and no prob 🙂

@callesonne callesonne merged commit e06a0c5 into google-deepmind:main Oct 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants