Add support for linking in the extension registry#23153
Add support for linking in the extension registry#23153chrstnb merged 7 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CLI's extension management capabilities by introducing support for linking extensions directly from local file paths. This feature is particularly useful for developers who want to test or use local versions of extensions without needing to publish them. The changes involve updates to the command handling, UI components, and underlying logic to facilitate this new linking mechanism, ensuring a smooth user experience and proper consent management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds support for linking local extensions within the CLI's extension registry. The changes are well-implemented, including updates to the UI components (ExtensionDetails, ExtensionRegistryView), the command action (linkAction), and corresponding test cases. The logic for determining linkable extensions and handling user consent is correctly integrated. Overall, the changes are clean and effectively deliver the new functionality.
Summary
The in-cli extension registry will now support linking if the source URI is from a filepath. The UI has been updated to give the user the choice between "Enter" for installing and "L" for linking.
Details
Added tests for linking logic.
Related Issues
Fixes #23152