Skip to content

Conversation

@LZRS
Copy link
Collaborator

@LZRS LZRS commented Oct 21, 2025

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2861

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS force-pushed the sdc-compose-dropdown branch 5 times, most recently from 2e9773f to 6f0ce2c Compare October 23, 2025 08:36
@LZRS LZRS force-pushed the sdc-compose-dropdown branch from 6f0ce2c to da3a8b7 Compare November 5, 2025 13:02
@LZRS LZRS marked this pull request as ready for review November 5, 2025 13:03
@LZRS LZRS requested a review from a team as a code owner November 5, 2025 13:03
@LZRS LZRS requested a review from MJ1998 November 5, 2025 13:03
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a video

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laz said this is actually an instrumentation test - in that case the file needs to be renamed.

if this is a problem with other compose tests we need to rename those test files too.

@github-project-automation github-project-automation bot moved this from New to PR under Review in Android FHIR SDK Nov 6, 2025
@LZRS
Copy link
Collaborator Author

LZRS commented Nov 10, 2025

Before

Screen_recording_20251111_001344.mp4

After

Screen_recording_20251111_011254.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: PR under Review

Development

Successfully merging this pull request may close these issues.

Migrate DropDownViewHolderFactory to compose

2 participants