Move AttachmentViewFactory to kmp#2939
Merged
LZRS merged 16 commits intoohs-foundation:masterfrom Feb 24, 2026
Merged
Conversation
# Conflicts: # datacapture-kmp/src/commonMain/kotlin/com/google/android/fhir/datacapture/QuestionnaireLists.kt
LZRS
force-pushed
the
kmp-attachment-wip
branch
2 times, most recently
from
db1debe to
53d2e23
Compare
LZRS
force-pushed
the
kmp-attachment-wip
branch
from
53d2e23 to
d4f2826
Compare
LZRS
force-pushed
the
kmp-attachment-wip
branch
from
d4f2826 to
e2ebbb6
Compare
ellykits
requested changes
Feb 17, 2026
...src/androidMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.android.kt
Show resolved
Hide resolved
...mmonMain/kotlin/com/google/android/fhir/datacapture/views/factories/AttachmentViewFactory.kt
Outdated
Show resolved
Hide resolved
...mmonMain/kotlin/com/google/android/fhir/datacapture/views/factories/AttachmentViewFactory.kt
Outdated
Show resolved
Hide resolved
...src/desktopMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.desktop.kt
Outdated
Show resolved
Hide resolved
...src/desktopMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.desktop.kt
Outdated
Show resolved
Hide resolved
...ure-kmp/src/iosMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.ios.kt
Show resolved
Hide resolved
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
ellykits
requested changes
Feb 23, 2026
...c/commonMain/kotlin/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItems.kt
Outdated
Show resolved
Hide resolved
ellykits
requested changes
Feb 23, 2026
...mmonMain/kotlin/com/google/android/fhir/datacapture/views/factories/AttachmentViewFactory.kt
Outdated
Show resolved
Hide resolved
...mmonMain/kotlin/com/google/android/fhir/datacapture/views/factories/AttachmentViewFactory.kt
Outdated
Show resolved
Hide resolved
...src/desktopMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.desktop.kt
Outdated
Show resolved
Hide resolved
ellykits
requested changes
Feb 23, 2026
Contributor
ellykits
left a comment
ellykits
left a comment
There was a problem hiding this comment.
Left a few comments. Please check.
LZRS
force-pushed
the
kmp-attachment-wip
branch
from
1ccaac2 to
74572f7
Compare
LZRS
force-pushed
the
kmp-attachment-wip
branch
from
74572f7 to
9d17aab
Compare
ellykits
requested changes
Feb 24, 2026
datacapture-kmp/src/commonMain/kotlin/com/google/android/fhir/datacapture/QuestionnaireLists.kt
Outdated
Show resolved
Hide resolved
...src/desktopMain/kotlin/com/google/android/fhir/datacapture/AttachmentMediaHandler.desktop.kt
Outdated
Show resolved
Hide resolved
ellykits
approved these changes
Feb 24, 2026
github-project-automation
bot
moved this from PR under Review
to Complete
in Android FHIR SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.