Skip to content

[FR] Enable running benchmarks in WebAssembly without filesystem #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juhanisimola-yousician opened this issue Mar 20, 2025 · 1 comment · May be fixed by #1956
Open

[FR] Enable running benchmarks in WebAssembly without filesystem #1952

juhanisimola-yousician opened this issue Mar 20, 2025 · 1 comment · May be fixed by #1956
Labels
enhancement good first issue help wanted

Comments

@juhanisimola-yousician
Copy link

juhanisimola-yousician commented Mar 20, 2025 •
edited
Loading

I've been using Benchmark for WebAssembly. It is working fine when virtual filesystem is enabled, but when built with -s FILESYSTEM=0, the run is aborted when GetCacheSizesFromKVFS tries to open /sys/devices/system/cpu/cpu0/cache/.

I think a simple solution would be to not call GetCacheSizesFromKVFS() when running on Emscripten, since the KVFS is never available in the virtual filesystem.
@XueSongTap
Copy link

Can I work on this？

@XueSongTap XueSongTap linked a pull request Mar 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Google Benchmark to run in WebAssembly with filesystem disabled XueSongTap/benchmark
3 participants
@LebedevRI @juhanisimola-yousician @XueSongTap