Skip to content

dev-tools (possibly other samples) is statically compiling its dependencies into what it publishes #2590

@RoboErikG

Description

@RoboErikG

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

dev-tools and possibly other plugins that depend on each other.

Description

dev-tools depends on a few other packages in samples, but instead of linking against them it's compiling all of their code into the published dev-tools package. The downstream effect of this is that if there's a version mismatch between block-tools and its dependencies (like block-test) anything that depends on dev-tools may get the wrong version.

I ran into this with browser tests which depends on dev-tools and block-test. Updating only the block-test version didn't do anything because it was only loading dev-tools and using the version that was compiled into it.

Reproduction steps

  1. In Blockly, update package.json to use dev-tools@9.0.0 and block-test@7.0.2
  2. Start the playground and switch to Test Blocks
  3. Check the Statement category and you'll see the version from block-test@7.0.0 instead of @7.0.2

Stack trace

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugSomething isn't working

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions