Skip to content

Conversation

rlconst
Copy link

@rlconst rlconst commented Sep 17, 2025

Without explicit type export I see an error

node_modules/@blockly/continuous-toolbox/src/index.ts (14:26): "LabelFlyoutItem" is not exported by "node_modules/@blockly/continuous-toolbox/src/ContinuousFlyout.ts", imported by "node_modules/@blockly/continuous-toolbox/src/index.ts".

Description

Without explivit type export I see an error `node_modules/@blockly/continuous-toolbox/src/index.ts (14:26): "LabelFlyoutItem" is not exported by "node_modules/@blockly/continuous-toolbox/src/ContinuousFlyout.ts", imported by "node_modules/@blockly/continuous-toolbox/src/index.ts".`
@rlconst rlconst requested a review from a team as a code owner September 17, 2025 05:16
@rlconst rlconst requested review from maribethb and removed request for a team September 17, 2025 05:16
Copy link

google-cla bot commented Sep 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rlconst
Copy link
Author

rlconst commented Sep 17, 2025

I've signed CLA

Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be necessary (get better build tooling!) but it doesn't have any serious downside unless we change LabelFlyoutItem from a pure type to a hybrid type/value (e.g. a class or enum) and forget to remove the type keyword here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants