Skip to content

Update appengine imports for external_testcase_reader. #4708

Closed
pgrace-google wants to merge 1 commit intogoogle:masterfrom
pgrace-google:fix-appengine
Closed

Update appengine imports for external_testcase_reader. #4708
pgrace-google wants to merge 1 commit intogoogle:masterfrom
pgrace-google:fix-appengine

Conversation

@pgrace-google
Copy link
Copy Markdown
Contributor

(drive by add additional component filter in query for extra safety)

@pgrace-google
Copy link
Copy Markdown
Contributor Author

(context failure logs: http://shortn/_BBefaIUwXU)

Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py Outdated
Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py
Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py
Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py Outdated
Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py
@pgrace-google
Copy link
Copy Markdown
Contributor Author

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

@alhijazi
Copy link
Copy Markdown
Contributor

alhijazi commented Mar 3, 2025

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

So the issue is coming from these two imports:

from appengine.libs import form
from appengine.libs import gcs

Looking at the other cron jobs in the same directory, I noticed non of them use appengine imports.

Also, I noticed that for cron jobs like cleanup (

# you may not use this file except in compliance with the License.
), there's an appengine cron handler called cleanup located here:
# you may not use this file except in compliance with the License.

Same pattern exists for predator_pull and triage in https://github.com/google/clusterfuzz/tree/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/appengine/handlers/cron.

The right approach might be similar to what was done for these three cron jobs.

Adding @jonathanmetzman as the code owner.

Comment thread src/clusterfuzz/_internal/cron/external_testcase_reader.py Outdated
@pgrace-google pgrace-google force-pushed the fix-appengine branch 2 times, most recently from 72d5d6f to 7eba2c8 Compare April 13, 2025 21:53
@github-actions
Copy link
Copy Markdown

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions Bot added the stale label Jun 13, 2025
@github-actions
Copy link
Copy Markdown

Automatically closing stale pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants