fix: use std::map for field ID mapping in ForAllFields#9026
Closed
matejsmycka wants to merge 1 commit intogoogle:masterfrom
Closed
fix: use std::map for field ID mapping in ForAllFields#9026matejsmycka wants to merge 1 commit intogoogle:masterfrom
matejsmycka wants to merge 1 commit intogoogle:masterfrom
Conversation
matejsmycka
force-pushed
the
fix-forallfields-oob-write
branch
from
6ecad4d to
d869797
Compare
matejsmycka
changed the title
Replace std::vector indexed by field->id() with std::map in both ForAllFields (reflection.cpp) and FieldIdToIndex (bfbs_gen.h).
matejsmycka
force-pushed
the
fix-forallfields-oob-write
branch
from
d869797 to
af958d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
std::vectorindexed byfield->id()withstd::mapinForAllFieldsandFieldIdToIndexto prevent OOB write when field IDs exceed field count in crafted.bfbsschemas.