fix: update dependencies to use new azure sdk components#2262
fix: update dependencies to use new azure sdk components#2262Subserial merged 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
464e0b1 to
866912e
Compare
|
@Subserial can you please review this PR when you get a chance. Thanks ! |
| // or the module requires newer Go features. To update the version used for CI | ||
| // and releases, update the ".go-version" file at the root of this repository. | ||
| go 1.25.0 | ||
| go 1.25.7 |
There was a problem hiding this comment.
We should not change this value from 1.25.0.
There was a problem hiding this comment.
Sure @Subserial, I'll make the change to use go version 1.25.0
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
===========================================
- Coverage 71.67% 52.93% -18.75%
===========================================
Files 123 165 +42
Lines 9935 11207 +1272
===========================================
- Hits 7121 5932 -1189
- Misses 2115 4561 +2446
- Partials 699 714 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Gagan H R <hrgagan4@gmail.com>
866912e to
acd1331
Compare
|
@Subserial I have made the changes. This PR now uses the go version 1.25.0 itself and only updates to use the modern dependency which uses the new azure sdk. |
Summary
Replace the unmaintained
github.com/chrismellard/docker-credential-acr-envwithgithub.com/gaganhr94/docker-credential-acr(v1.0.1) for Azure Container Registryauthentication.
The old library depends on the deprecated
Azure/go-autorestSDK which is no longermaintained. The new library uses the modern Azure SDK (
azidentity+azcontainerregistry) and provides anauthn.Helpercompatible withgo-containerregistry's
MultiKeychain, matching the existing pattern used by the ECRand Alibaba ACR helpers.
Closes #2003