Skip to content

fix: update dependencies to use new azure sdk components#2262

Merged
Subserial merged 1 commit intogoogle:mainfrom
gaganhr94:fix/update-to-new-azure-sdk
Apr 14, 2026
Merged

fix: update dependencies to use new azure sdk components#2262
Subserial merged 1 commit intogoogle:mainfrom
gaganhr94:fix/update-to-new-azure-sdk

Conversation

@gaganhr94
Copy link
Copy Markdown
Contributor

Summary

Replace the unmaintained github.com/chrismellard/docker-credential-acr-env with
github.com/gaganhr94/docker-credential-acr (v1.0.1) for Azure Container Registry
authentication.

The old library depends on the deprecated Azure/go-autorest SDK which is no longer
maintained. The new library uses the modern Azure SDK (azidentity +
azcontainerregistry) and provides an authn.Helper compatible with
go-containerregistry's MultiKeychain, matching the existing pattern used by the ECR
and Alibaba ACR helpers.

Closes #2003

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 13, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gaganhr94 gaganhr94 force-pushed the fix/update-to-new-azure-sdk branch 2 times, most recently from 464e0b1 to 866912e Compare April 13, 2026 19:14
@gaganhr94
Copy link
Copy Markdown
Contributor Author

@Subserial can you please review this PR when you get a chance. Thanks !

Comment thread pkg/authn/k8schain/go.mod Outdated
// or the module requires newer Go features. To update the version used for CI
// and releases, update the ".go-version" file at the root of this repository.
go 1.25.0
go 1.25.7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change this value from 1.25.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @Subserial, I'll make the change to use go version 1.25.0

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.93%. Comparing base (8b3c303) to head (acd1331).
⚠️ Report is 90 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8b3c303) and HEAD (acd1331). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8b3c303) HEAD (acd1331)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2262       +/-   ##
===========================================
- Coverage   71.67%   52.93%   -18.75%     
===========================================
  Files         123      165       +42     
  Lines        9935    11207     +1272     
===========================================
- Hits         7121     5932     -1189     
- Misses       2115     4561     +2446     
- Partials      699      714       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gagan H R <hrgagan4@gmail.com>
@gaganhr94 gaganhr94 force-pushed the fix/update-to-new-azure-sdk branch from 866912e to acd1331 Compare April 14, 2026 13:47
@gaganhr94
Copy link
Copy Markdown
Contributor Author

@Subserial I have made the changes. This PR now uses the go version 1.25.0 itself and only updates to use the modern dependency which uses the new azure sdk.

@Subserial Subserial merged commit 7a66278 into google:main Apr 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ggcr: https://github.com/Azure/go-autorest is deprecated

3 participants