ci(spanner): run spanner integration tests against prod (#6888)

Execute the Spanner integration tests against prod from the
`integration-daily` build.

The Spanner samples/tests have cases that are skipped or
short-circuited when running against the emulator, so we lost
some coverage when we move to using the emulator exclusively
from the "normal" builds.  Now we'll at least hit those cases
during `integration-daily`.

Author: devbww

ci/cloudbuild/builds/integration-daily.sh

@@ -23,7 +23,7 @@
 # `ci/cloudbuild/triggers` directory. "Manual" triggers exist only within the
 # GCB UI at the time of this writing. Users with the appropriate access can run
 # this build by hand with:
-#   `ci/cloudbuild/build.sh --distro fedora integration-daily --project cloud-cpp-testing-resources`
+#   `ci/cloudbuild/build.sh --distro fedora-34 integration-daily --project cloud-cpp-testing-resources`
 
 set -eu
 
@@ -44,3 +44,7 @@ export GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS="instance,backup"
 export GOOGLE_CLOUD_CPP_IAM_QUOTA_LIMITED_INTEGRATION_TESTS="yes"
 mapfile -t integration_args < <(integration::bazel_args)
 integration::bazel_with_emulators test "${args[@]}" "${integration_args[@]}"
+
+io::log_h2 "Running Spanner integration tests (against prod)"
+bazel test "${args[@]}" "${integration_args[@]}" \
+  --test_tag_filters="integration-test" google/cloud/spanner/...

ci/cloudbuild/builds/lib/integration.sh

@@ -41,7 +41,7 @@ curl -sSL --retry 10 -o /dev/shm/roots.pem https://pki.google.com/roots.pem
 #
 #   mapfile -t args < <(bazel::common_args)
 #   mapfile -t integration_args < <(integration::bazel_args)
-#   integration::bazel_with_emulators test "${args[@]}" "${integration_args}"
+#   integration::bazel_with_emulators test "${args[@]}" "${integration_args[@]}"
 #
 function integration::bazel_args() {
   declare -a args
@@ -134,7 +134,7 @@ function integration::bazel_args() {
 #
 #   mapfile -t args < <(bazel::common_args)
 #   mapfile -t integration_args < <(integration::bazel_args)
-#   integration::bazel_with_emulators test "${args[@]}" "${integration_args}"
+#   integration::bazel_with_emulators test "${args[@]}" "${integration_args[@]}"
 #
 function integration::bazel_with_emulators() {
   readonly EMULATOR_SCRIPT="run_integration_tests_emulator_bazel.sh"

google/cloud/spanner/testing/policies.h

@@ -25,9 +25,8 @@ namespace google {
 namespace cloud {
 namespace spanner_testing {
 inline namespace SPANNER_CLIENT_NS {
-// For some tests, use 15 minutes as the maximum polling and retry periods. The
-// default is longer, but we need to timeout earlier in the CI builds.
-auto constexpr kMaximumWaitTimeMinutes = 15;
+
+auto constexpr kMaximumWaitTimeMinutes = 30;  // test timeout notwithstanding
 auto constexpr kBackoffScaling = 2.0;
 
 inline std::unique_ptr<spanner::RetryPolicy> TestRetryPolicy() {