[refactor] Doubled "Container" component #1136
mateuszmazurek
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I created issue #1135 but it has been "automatically closed because it does not follow the issue template.". There's no adequate issue template for my case so I will paste it here.
I found one confusing thing while working on some feature (it will allow even more customization) for this lib.
We have
styleprop which can be used to apply additional styling "at the sheet container" (as docs says). InsideBottomSheetcomponent you use internalBottomSheetContainercomponent which can be styled using undocumented (but typed)containerStyleprop.Both props are used to style container but:
containerStyleprop so as not to mislead this library users ("two containers? wtf?")I need to name this "public" container (this styled using
styleprop, rawAnimated.View, child of currentBottomSheetContainer) for the purpose of feature I work on but I'm not convinced by any of my ideas. I'm thinking of renamingBottomSheetContainerto(edited)BottomSheetRootBottomSheetRootContainer(or something similar) and useBottomSheetContainername for the "container" mentioned in docs (this "public" one). Is it good direction? What do you think @gorhom?Beta Was this translation helpful? Give feedback.
All reactions