Open
Conversation
|
Russell Banks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
Won't run checks as they are destined for failure. |
|
@Eskaan can you please review and merge? |
Collaborator
|
I am going through everything atm. One after another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a workflow that automatically publishes GDLauncher to WinGet every release. It would replace GDLauncher being automated by vedantmgoyal2009/winget-pkgs-automation (This workflow is made by the same person that made winget-pkgs-automation). Please do not merge this pull request without reading the below and making the required changes (The token part is the important bit) :)
installers-regex: '\.exe$'This will include all
.exefiles in the assets of the latest GDLauncher release (GDLauncher-win-setup.exe) in the pull request.token: ${{ secrets.WINGET_TOKEN }}This is the bit that will require action from the person whose account will be used for the pull requests (a member of the gorila-devs GitHub organisation). This is a GitHub token with which the action will authenticate with GitHub and create a pull request on the winget-pkgs repository.
To do this, you will need to:
public_reposcope.WINGET_TOKEN.See using encrypted secrets in a workflow for more details.
Finally, a fork of winget-pkgs needs to be created under the gorilla-devs organisation. Please do not delete the fork after a pull request has been merged as the action will use that fork for making a branch and merging it with the upstream winget-pkgs repository on every GDLauncher release.
If you would like to read about this action further, the source code and documentation are here.