Skip to content

Conversation

mabruzzo
Copy link
Collaborator

This introduces a few assorted tweaks required for the 3.4 release:

  1. A longstanding bug is fixed in the Fortran Bindings (according to @brittonsmith, it only caused problems on macOS -- it shocked me that the Fortran Bindings ever worked)
  2. All references have been removed about the GRACKLE_DATA_DIR env variable. An upcoming PR (Auto File Management Part 1: Introducing a Datafile Management Tool #235) is going to overhaul this machinery, but it probably won't be merged before the 3.4 release
  3. I deleted an unnecessary file that had been introduced while introducing the googletest machinery. I think the file was intended to be a placeholder. But, it's not used and is a little confusing (especially since it isn't aligned with the current direction for transcription)

1. A bug is fixed in the Fortran Bindings
2. All references have been removed about the ``GRACKLE_DATA_DIR`` env
   variable. An upcoming PR (grackle-project#235) is going to overhaul this machinery,
   but it probably won't be merged the 3.4 release
@mabruzzo mabruzzo added this to the 3.4 milestone Mar 18, 2025
@mabruzzo mabruzzo force-pushed the FBindingBugfix-3.4Tweaks branch from bb5dcdd to 18a74e5 Compare March 18, 2025 12:52
@brittonsmith brittonsmith merged commit 04f74b4 into grackle-project:main Mar 18, 2025
4 checks passed
@mabruzzo mabruzzo deleted the FBindingBugfix-3.4Tweaks branch May 23, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants