[newchem-cpp] support C++ files with .cpp
suffix
#398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This lays the ground work for changing the suffix of C++ files from
.C
to.cpp
This may seem stupid, but it's annoyingly important
Context and Motivation
For context, the historic convention in Grackle project was to use .C as the suffix for C++ source files. Thus, when we began transcribing files, we used the .C suffix (even though it is a less common choice than
.cpp
)However, it turns out that converting a file named
<prefix>.c
to<prefix>.C
causes lots of issues performing Git operations when your machine has a case-insensitive file-system (common on macOS). This comes up in operations as simple as changing between 2 branches (Example: if you haveinitialize_chemistry_data.c
in one branch you simply cannot change to a branch withinitialize_chemistry_data.C
)Consequently, we will be transitioning to the
.cpp
suffix