[newchem-cpp] convert some initialization files to C++ #400
+263
−220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For context, the historic convention in Grackle project was to use .C as the suffix for C++ source files. Thus, when we began transcribing files, we used the .C suffix (even though it is a less common choice than .cpp) However, it turns out that converting a file named `<prefix>.c` to `<prefix>.C` causes lots of issues performing Git operations when your machine has a case-insensitive file-system (common on macOS). This comes up in operations as simple as changing between 2 branches Consequently, we will be transitioning to the .cpp suffix
A few tweaks were necessary: - I needed to add the `extern "C"` annotation to a number of functions that are publicly exposed as the C API - I removed the leading underscore from some internal helper functions - I needed to tweak make the group name argument passed to initialize_cloudy_data expect a `const char*`, rather than just a `char*`. This is essential since we are passing a string literal (this was a very minimal change) I also added to the `static` specifier to some internal functions (this ensures that these helper functions will not be accessible to external code)
mabruzzo
force-pushed
the
ncc-initialize-chem-cpp
branch
from
bcab799 to
faddb23
Compare
I also renamed initialize_rates.h to initialize_rates.hpp to denote that the header is **ONLY** compatible with C++ source files
mabruzzo
force-pushed
the
ncc-initialize-chem-cpp
branch
from
faddb23 to
0f75d2d
Compare
mabruzzo
force-pushed
the
ncc-initialize-chem-cpp
branch
from
0f75d2d to
142d9de
Compare
mabruzzo
force-pushed
the
ncc-initialize-chem-cpp
branch
from
142d9de to
c2c1a5d
Compare
brittonsmith
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this must be reviewed after #397 and #398 are merged
This converts some initialization routines to C++. This is part of the plan to transcribe
lookup_rate_cool_1dIt may be easier to review this commit-by-commit (the PR is only 5 commits)