Support projects without a buildfile in the root #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid multi project builds may not have a build file in the root project, and the current code does not generate autocomplete information for tasks if the build file is not found. It assumes the directory is not an initialized gradle project. See #137.
This PR is a possible solution for this problem, is what I did, so I can use it. It works by not requiring the build file if the settings file is found.
Then, the call to the gradle executable is performed by path, instead of by build file in that case. Is the fix that I found less disruptive, but may not be ideal. It will create the cache as if the build file
build.gradle.ktswas present. This should not cause any trouble, but it is somehow weird. Another option would be to set the name for the cache directory, based on the project directory path.Anyway, this PR is here just to illustrate more what was mentioned in issue #137, but I'm willing to perform modifications to make it better if this is considered a valid path.
Issue: #137