Skip to content

Conversation

Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Sep 5, 2025

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

happy ci:

related to:

Signed-off-by: Vincent Potucek <vpotucek@me.com>
Co-authored-by: Vincent Potucek <vpotucek@me.com>
Signed-off-by: Vincent Potucek <vpotucek@me.com>
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Sep 5, 2025
@Pankraz76 Pankraz76 marked this pull request as ready for review September 5, 2025 14:54
@Pankraz76 Pankraz76 requested review from a team as code owners September 5, 2025 14:54
@Pankraz76 Pankraz76 requested review from big-guy, alllex and asodja and removed request for a team September 5, 2025 14:54
@alllex alllex removed their request for review September 5, 2025 18:02
@ov7a ov7a self-assigned this Sep 8, 2025
@ov7a
Copy link
Member

ov7a commented Sep 9, 2025

@bot-gradle test this

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

The following builds have failed:

@ov7a
Copy link
Member

ov7a commented Sep 9, 2025

Thank you for your contribution!

This PR is complete and simple enough, it will be merged immediately.


The following builds have failed:

These are false positives.

@ov7a ov7a added this pull request to the merge queue Sep 9, 2025
@bot-gradle bot-gradle added this to the 9.2.0 RC1 milestone Sep 9, 2025
@ov7a ov7a added in:building-gradle gradle/gradle build and removed to-triage labels Sep 9, 2025
Merged via the queue into gradle:master with commit a5a7ffd Sep 9, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:building-gradle gradle/gradle build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants