Replace setKioskmode() with &kiosk query param

[intermittentnrg]

Alternative to #53

Probably need to update loadDashboard() in grafana-studio.js also.

[intermittentnrg]

What is the point of loadDashboard() in grafana-studio.js? https://github.com/grafana-toolbox/grafanimate/blob/main/grafanimate/grafana-studio.js#L99-L108
It's just reimplementation of make_grafana in core.py? https://github.com/grafana-toolbox/grafanimate/blob/main/grafanimate/core.py#L35-L48

Is it to support login or? For me it would make sense to delete the javascript version.

[amotl]

Thank you very much. What do you think about this patch, @maurerle?

[maurerle]

What is the point of loadDashboard() in grafana-studio.js?
There is the functionality to have a list of dashboards or panels or something in which the navigation happens completely in JS.
Though I do not think it is used for now.

So I am fine with removing this :)
Patch looks good from my side.

Login does currently rely on one request to do the login and a second python request to show the dashboard - while the grafana-studio.js is injected freshly into the page, so this does not rely on the js version of loadDashboard as well.

Did you test this? Then it is fine from my side :)

[intermittentnrg]

I mean I used to set the full dashboard URL from GRAFANA_URL, completely removing the need for loadDashboard() to generate the URL. Never quite understood the need for dashboard uid param.

I do not use or test login with grafana builtin auth, I instead use reverse proxy auth using oauth2-proxy. And I just bypass the auth when running grafanimate.

I am using this code locally and have tested it, but may not have tested everything like login, and have made other changes also.

[maurerle]

@intermittentnrg would you like to rebase the PR and set it ready?

[amotl]

Thank you. Approving this, as there are no other objections. If someone needs the features you may remove hereby, it will not be too difficult to bring them back.

[amotl]

Hi again. It looks like this patch has been left behind. As there are no objections about merging it, we are inclined to bring it into mainline when tests pass and draft mode is gone.

@intermittentnrg: Would you like to refresh your patch and just remove the code you deactivated, to leave no clutter behind?