Templating: Do not run templating engine on json files. Use the .json.hbs extension for templating

Author: john-scalingo

src/util/localfs.js

@@ -1,11 +1,10 @@
 const _ = require('lodash');
 const fs = require('fs');
 
+const Handlebars = require('handlebars');
 const Logger = require('./logger.js');
 
 const logger = new Logger('localfs');
-const Handlebars = require("handlebars");
-
 
 function LocalFS() {}
 
@@ -29,26 +28,52 @@ LocalFS.prototype.checkExists = function(name, output, showOutput) {
     }
     return true;
   }
+
+  if (fs.existsSync(`${name}.hbs`)) {
+    if (showOutput) {
+      logger.showResult(`A template file exists for ${output}.`);
+    }
+    return true;
+  }
+
   if (showOutput) {
     logger.justShow(`${output} does not exists.`);
   }
+
   return false;
 };
 
 LocalFS.prototype.readFile = function(name, _showOnError) {
-  let templateSrc = fs.readFileSync(name, 'utf8', function(error, data) {
+  let useTemplating = false;
+
+  // if a file with a .hbs exist, use it for templating
+  if (fs.existsSync(`${name}.hbs`)) {
+    name = `${name}.hbs`;
+    useTemplating = true;
+  }
+
+  // Read the 'name' file (or the 'name.tml')
+  const src = fs.readFileSync(name, 'utf8', (error, _data) => {
     if (!error) {
       logger.showResult(`Read file ${name} successfully.`);
     } else {
       logger.showError(`Error in reading file ${name}`);
     }
   });
-  if(templateSrc === null) {
-    return null
+
+  // If the file was not found (or cannot be read)
+  if (src === null) {
+    return null;
   }
 
-  var template = Handlebars.compile(templateSrc)
-  return template(process.env)
+  // if the file is not a template file
+  if (!useTemplating) {
+    return src;
+  }
+  logger.showResult(`Running templating engine on ${name}`);
+  // If the file is a template file, let handlebars do its magic
+  const template = Handlebars.compile(src);
+  return template(process.env);
 };
 
 LocalFS.prototype.writeFile = function(name, content) {
@@ -91,7 +116,7 @@ LocalFS.prototype.writeStream = function(name) {
 };
 
 LocalFS.prototype.getFileName = function(fileNameWithExtension) {
-  return fileNameWithExtension.replace(/\.[^/.]+$/, '');
+  return fileNameWithExtension.replace(/\..+$/, '');
 };
 
 module.exports = LocalFS;