-
Notifications
You must be signed in to change notification settings - Fork 61
PoC: Add support for templating #148
base: master
Are you sure you want to change the base?
Conversation
Small demo: https://streamable.com/7lghf |
That is very nice! I feel like the original author is not maintaining the lib anymore. I think it would be worth forking or asking him to have a new maintainer. |
Thanks. Good idea having a way to store those variables in a file can be cool. |
Yeah that's what I feared (for import), maybe a good first step would be to warn the user if he overrides a template? It would be nice to be able to be able to modify a dashboard in grafana and still be able to import the diff. I am not sure I would put it all in |
Feel free to merge this PR guys, you both have the ability to merge the PRs to the project. I will work on the Release and Org side so that you guys have more control on this project. |
Detecting if the template has been modified by the user or if the remote had changed is not an easy task. We could add the templating engine only if the file has a particular extension (like: |
Do you plan to finish the feature and add tests for it? It would be nice to have the feature land in 0.8.0. |
….hbs extension for templating
7bfeee2
to
327fd82
Compare
Hi there What does this PR miss to be merged ? |
Heee let me review it, I am also super busy |
This is a basic support for templating in wizzy.
Adding it ad the fs part make it really easy and makes templating available for every wizzy resources.
The templating engine used is handlebars: http://handlebarsjs.com/