fix(loki.source.podlogs): conditionally register field index for spec.nodeName #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….nodeName Only register the Kubernetes field index for spec.nodeName when node filtering is enabled. This prevents 'Index with name field:spec.nodeName does not exist' errors when the node_filter configuration is used. The field index is now registered conditionally based on: - nodeFilterEnabled flag is true - getNodeFilterName() returns a non-empty string This optimization avoids unnecessary field index registration when node filtering is not in use, improving performance and preventing runtime errors.
|
I'm not familiar with this issue, but I'm a bit confused looking at the diff - the changelog/description claims this changes behavior when node filter is not configured, but all the diff shows is new behavior when node filter is configured. Can you help me understand? |
QuentinBisson
commented
Oct 22, 2025
|
@dehaansa you are totally right, the description and changelog entry were totally wrong. This pull request enables the field indexing if the node filtering is enabled |
kalleep
approved these changes
Oct 29, 2025
|
Thank you @kalleep :) Do you know when it might be released? |
|
@QuentinBisson If we don't do a patch release this will be release around 2025-11-11 when we are scheduled for our next minor |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Registers the Kubernetes field index for spec.nodeName when node filtering is enabled. This prevents
Index with name field:spec.nodeName does not existerrors when the node_filter configuration is used.Notes to the Reviewer
The field index is registered conditionally (to avoid unnecessary field index registation) based on:
PR Checklist