fix: trigger the sync job when targets are updated #4635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
thampiotr
reviewed
Oct 21, 2025
thampiotr
reviewed
Oct 21, 2025
CHANGELOG.md
Outdated
|
|
||
| - `prometheus.exporter.postgres` dependency has been updated to v0.18.1. This includes new `stat_progress_vacuum` and `buffercache_summary` collectors, as well as other bugfixes and enhancements. (@cristiangreco) | ||
|
|
||
| - `local.file_match` will now trigger it's sync job when the component is updated with new targets. (@kalleep) |
There was a problem hiding this comment.
That's a bit of an implementation detail. I think you want to write a bugfix message on what this fixes.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the local.file_match component to trigger its sync job immediately whenever the component is updated with new targets, rather than only syncing on startup or timer expiration. This improves responsiveness when used with discovery mechanisms by exporting new targets as soon as discovery data changes.
Key changes:
- Introduced a buffered channel to signal target changes and trigger immediate syncs
- Changed from
RWMutextoMutexfor simpler locking semantics - Refactored the Run loop to handle both timer-based and change-triggered syncs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/component/local/file_match/file.go | Added targetsChanged channel to trigger immediate syncs on component updates; refactored Run loop to handle both timer-based and event-driven syncs |
| CHANGELOG.md | Documented the new behavior of triggering sync jobs on component updates |
kalleep
force-pushed
the
kalleep/local-file-match-new-targets
branch
from
a46cdd8 to
84c98d2
Compare
kalleep
force-pushed
the
kalleep/local-file-match-new-targets
branch
from
84c98d2 to
25824ad
Compare
kalleep
changed the title
thampiotr
approved these changes
Oct 22, 2025
kalleep
added a commit
that referenced
this pull request
Oct 23, 2025
* fix: trigger the sync job whenever the component is updated with new targets
kalleep
added a commit
that referenced
this pull request
Oct 27, 2025
* fix: trigger the sync job when targets are updated (#4635) * Fix splunkhec arguments missing new block (#4612) * Fix CRD translations to propagate scrape protocols (#4638) * fix: loki source file scheduleloop (#4634) * fix: panic when no tcp block is used for otelcol.receiver.syslog (#4628) * Expose ARP collector config options. (#4669) --------- Co-authored-by: Sam DeHaan <sam.dehaan@grafana.com> Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Extracted from #4611
Before this component would only export new targets whenever it started or if the timer was triggered. When using this component with discovery mechanism it is useful to "expand" paths and exports as soon as we have new discovery data.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist