Skip to content

Conversation

ashharrison90
Copy link
Contributor

  • changes needed to support new JSX runtime
  • bump major version

prereq for grafana/grafana#88802

won't merge and release until we're all ready in core as well 👍

@ashharrison90 ashharrison90 self-assigned this Jun 17, 2024
@ashharrison90 ashharrison90 changed the title Changes needed to support new jsx runtime Changes for new jsx runtime and bump major version Jun 17, 2024
@jackw
Copy link
Contributor

jackw commented Jun 19, 2024

won't merge and release until we're all ready in core as well 👍

This package is also used by plugins. If a plugin dev updates this will they need to update their tsconfig config and webpack config too?

@ashharrison90
Copy link
Contributor Author

won't merge and release until we're all ready in core as well 👍

This package is also used by plugins. If a plugin dev updates this will they need to update their tsconfig config and webpack config too?

won't merge and release until we're all ready in core as well 👍

This package is also used by plugins. If a plugin dev updates this will they need to update their eslint config and webpack config too?

yes. do plugins typically manage their own dependencies, or do they rely on create-plugin to update them? or some mixture of both? 🤔

either way, we should probably add a CHANGELOG to this repo to explain the changes. it will be something like:

  • update tsconfig-grafana as well
  • update the build to use new jsx runtime (this step will vary depending on the existing build, e.g. babel, esbuild, etc.)
  • run the react codemod on the plugin code

Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this as the changes here will force plugins to use auto jsx which right now will bundle jsx-runtime into the plugin. This will cause the plugin to break when loaded in a version of Grafana running React 19. See this comment in the community team React 19 epic for further info.

We will get there but I don't want this creeping in and causing us more bother with the upgrade path for plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants