Skip to content

Commit 0d76100

Browse files
authored
Fix minor issues in the tutorial and local setup (#165)
Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>
1 parent 4755dcb commit 0d76100

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

cmd/grafana-app-sdk/templates/local/generated/grafana.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ spec:
111111
- name: GF_INSTALL_PLUGINS
112112
- name: GF_PATHS_CONFIG
113113
value: /etc/grafana-config/grafana.ini
114-
image: grafana/grafana-enterprise:9.5.8
114+
image: grafana/grafana-enterprise:10.0.3
115115
imagePullPolicy: IfNotPresent
116116
name: grafana
117117
ports:

cmd/grafana-app-sdk/templates/local/generated/operator.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: default
66
---
77
{{ range $.CRDs }}apiVersion: rbac.authorization.k8s.io/v1
8-
kind: RoleBinding
8+
kind: ClusterRoleBinding
99
metadata:
1010
name: operator:{{.MachineName}}-user-rolebinding
1111
namespace: default

docs/tutorials/issue-tracker/06-frontend.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ We're still going to keep our front-end pretty simple, so all we're going to do
99
In the future, the `project add frontend` will auto-generate this boilerplate client, but for now, we have to write it ourselves.
1010
For this tutorial, we have one pre-written, that we'll discuss a few parts of. Either create a new file called `plugin/src/api/issue_client.ts` and [copy the contents of this file into it](frontend-files/issue-client.ts), or run the following to do it automatically:
1111
```bash
12-
curl -o plugin/src/api/issue_client.ts https://github.com/grafana/grafana-app-sdk/blob/main/docs/tutorials/issue-tracker/frontend-files/issue-client.ts
12+
curl -o plugin/src/api/issue_client.ts https://raw.githubusercontent.com/grafana/grafana-app-sdk/main/docs/tutorials/issue-tracker/frontend-files/issue-client.ts
1313
```
1414

1515
A few things to note in our client:
@@ -37,7 +37,7 @@ The rest of the client uses grafana libraries to make fetch requests to perform
3737
We already have a very empty generated main page located at `plugin/src/pages/main.tsx`. We're going to overwrite all of this with new contents.
3838
Either copy [the contents of this file](frontend-files/main.tsx) into `plugin/src/pages/main.tsx` (overwriting the current contents), or do it with curl:
3939
```bash
40-
curl -o plugins/src/pages/main.tsx https://github.com/grafana/grafana-app-sdk/blob/main/docs/tutorials/issue-tracker/frontend-files/main.tsx
40+
curl -o plugin/src/pages/main.tsx https://raw.githubusercontent.com/grafana/grafana-app-sdk/main/docs/tutorials/issue-tracker/frontend-files/main.tsx
4141
```
4242

4343
TODO: breakdown of the file contents?

docs/tutorials/issue-tracker/frontend-files/issue-client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Issue as generatedIssue } from '../generated/issue_types.gen';
1+
import { Issue as generatedIssue } from '../generated/issue/v1/types.gen';
22
import { BackendSrvRequest, getBackendSrv, FetchResponse } from '@grafana/runtime';
33
import { lastValueFrom } from 'rxjs';
44
import { PLUGIN_API_URL } from '../constants';

docs/tutorials/issue-tracker/frontend-files/main.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ export const MainPage = () => {
106106
key="delete-issue"
107107
name="trash-alt"
108108
size={'md'}
109+
aria-label="delete-issue"
109110
onClick={() => {
110111
deleteIssue(issue.staticMetadata.name);
111112
}}

0 commit comments

Comments
 (0)