[tempo-distributed] Add action to the servicemonitor relabling for the cluster label #3935
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stuart Auchterlonie <stuarta@squashedfrog.net>
stuarta
requested review from
a team,
BitProcessor,
Sheikh-Abubaker,
faustodavid and
swartz-k
as code owners
stuarta
changed the title
|
@stuarta can you bump the chart version? |
@QuentinBisson done |
QuentinBisson
approved these changes
Oct 16, 2025
|
@stuarta Can you check the DCO? Your commits need to be signed |
stuarta
force-pushed
the
tempo-distributed-fix-servicemonitor-for-use-with-argocd
branch
from
a7fe9ac to
73baf8e
Compare
@QuentinBisson i've amended the version bump to include sign off |
Signed-off-by: Stuart Auchterlonie <stuarta@squashedfrog.net>
stuarta
force-pushed
the
tempo-distributed-fix-servicemonitor-for-use-with-argocd
branch
from
73baf8e to
786714c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the servicemonitor template is missing the action on the
targetLabel: clusterrelabelings.Whilst this is valid, k8s adds in the default
action: replacewhen the servicemonitor is deployed.If you use ArgoCD to deploy tempo, with the servicemonitors enabled, this results in a delta between the desired state and the live state. Thus argo is constantly in a sync loop, trying to remediate the on-cluster state.
This PR adds action: replace to the servicemonitor template, allowing argocd to successfully apply the desired configuration.