Skip to content

Commit a2a77c0

Browse files
anggerdeniivkalitaJayclifford345JStickler
authored
feat(helm): add ability to specify index-gateway container lifecycle (#19573)
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Ivan Kalita <ivan.kalita@grafana.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
1 parent 5de126b commit a2a77c0

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed

docs/sources/setup/install/helm/reference.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5456,6 +5456,7 @@ null
54565456
},
54575457
"initContainers": [],
54585458
"joinMemberlist": true,
5459+
"lifecycle": {},
54595460
"maxUnavailable": null,
54605461
"nodeSelector": {},
54615462
"persistence": {
@@ -5634,6 +5635,15 @@ null
56345635
<td><pre lang="json">
56355636
true
56365637
</pre>
5638+
</td>
5639+
</tr>
5640+
<tr>
5641+
<td>indexGateway.lifecycle</td>
5642+
<td>object</td>
5643+
<td>Lifecycle for the index-gateway container</td>
5644+
<td><pre lang="json">
5645+
{}
5646+
</pre>
56375647
</td>
56385648
</tr>
56395649
<tr>

production/helm/loki/CHANGELOG.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ Entries should include a reference to the pull request that introduced the chang
1313

1414
## Unreleased
1515

16-
- [BUGFIX] Wrong context passed to loki.namespace helper from table manager servicemonitor. [#19461](https://github.com/grafana/loki/pull/19461)
1716
- [CHANGE] Remove unused `storageClass` field from compactor persistence configuration. Storage class should be configured per-claim in the `claims` array instead.[#19443](https://github.com/grafana/loki/pull/19443)
1817
- [FEATURE] Make loki-canary readinessProbe configurable via values.yaml [#19328](https://github.com/grafana/loki/pull/19328)
19-
- [FEATURE]: Allow auto-resizing the volume by recreating the StatefulSet. [#19217](https://github.com/grafana/loki/pull/19217)
20-
- [BUGFIX] Add single-binary component to ingress NetworkPolicy [#19229](https://github.com/grafana/loki/pull/19229)
21-
- [BUGFIX] Use strings in stead of integers for ports in CiliumNetworkPolicies [#19252](https://github.com/grafana/loki/pull/19252)
2218
- [ENHANCEMENT] Update default readiness probe values to match operator [#19529](https://github.com/grafana/loki/pull/19529)
23-
- [ENHANCEMENT] Allow configuration of alert rule severities and thresholds
19+
- [ENHANCEMENT] Allow configuration of alert rule severalties and thresholds[#13730](https://github.com/grafana/loki/pull/13730)
20+
- [ENHANCEMENT] Standardize global image registry configuration to match other Grafana charts [#19246](https://github.com/grafana/loki/pull/19246)
21+
- [ENHANCEMENT] Add the ability to specify index-gateway container lifecycle. [#19573](https://github.com/grafana/loki/pull/19573)
22+
- [BUGFIX] Move bucketName validations into the config helpers.[#19051](https://github.com/grafana/loki/pull/19051)
23+
- [BUGFIX] Standardize global image registry to match other Grafana charts [#19246](https://github.com/grafana/loki/pull/19246)
2424

2525
## 6.44.0
2626

@@ -58,7 +58,6 @@ Before upgrading to this version, make sure that the CustomResourceDefinitions (
5858

5959
- [BUGFIX] Explicitly set registry for k8s-sidecar image [#19233](<https://github.com/grafana/loki/pull/19233>]
6060
- [ENHANCEMENT] Add configurable `livenessProbe` and `startupProbe` for the nginx container in the gateway pods. [#18545](https://github.com/grafana/loki/pull/18545)
61-
- [ENHANCEMENT] Standardize global image registry configuration to match other Grafana charts [#19246](https://github.com/grafana/loki/pull/19246)
6261

6362
## 6.40.0
6463

production/helm/loki/templates/index-gateway/statefulset-index-gateway.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,10 @@ spec:
130130
{{- end }}
131131
resources:
132132
{{- toYaml .Values.indexGateway.resources | nindent 12 }}
133+
{{- with .Values.indexGateway.lifecycle }}
134+
lifecycle:
135+
{{- toYaml . | nindent 12 }}
136+
{{- end }}
133137
{{- if .Values.indexGateway.extraContainers }}
134138
{{- toYaml .Values.indexGateway.extraContainers | nindent 8}}
135139
{{- end }}

production/helm/loki/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2598,6 +2598,8 @@ indexGateway:
25982598
initContainers: []
25992599
# -- Grace period to allow the index-gateway to shutdown before it is killed.
26002600
terminationGracePeriodSeconds: 300
2601+
# -- Lifecycle for the index-gateway container
2602+
lifecycle: {}
26012603
# -- Affinity for index-gateway pods.
26022604
# @default -- Hard node anti-affinity
26032605
# The value will be passed through tpl.

0 commit comments

Comments
 (0)