From 4906f8cbfa5efece917fbada70facac222b27364 Mon Sep 17 00:00:00 2001 From: Vishwanath Bhat <76242298+Vishwanath2001@users.noreply.github.com> Date: Thu, 9 Oct 2025 12:07:58 +0530 Subject: [PATCH 1/3] chore(helm): remove unused and redundant field from values.yaml compactor.persistance.size and compactor.persistance.storageClass is not being used in template and is confusing . as both of these are configured inside claims Signed-off-by: Vishwanath Bhat <76242298+Vishwanath2001@users.noreply.github.com> --- production/helm/loki/values.yaml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/production/helm/loki/values.yaml b/production/helm/loki/values.yaml index 1b70ab513fc4a..8d300b99ac93b 100644 --- a/production/helm/loki/values.yaml +++ b/production/helm/loki/values.yaml @@ -2722,14 +2722,6 @@ compactor: persistence: # -- Enable creating PVCs for the compactor enabled: false - # -- Size of persistent disk - size: 10Gi - # -- Storage class to be used. - # If defined, storageClassName: . - # If set to "-", storageClassName: "", which disables dynamic provisioning. - # If empty or set to null, no storageClassName spec is - # set, choosing the default provisioner (gp2 on AWS, standard on GKE, AWS, and OpenStack). - storageClass: null # -- List of the compactor PVCs # @notationType -- list claims: From a0a143d7e331ff1eedcca58c6bb8bc875eb25a94 Mon Sep 17 00:00:00 2001 From: Vishwanath Bhat <76242298+Vishwanath2001@users.noreply.github.com> Date: Thu, 9 Oct 2025 12:39:43 +0530 Subject: [PATCH 2/3] Update CHANGELOG.md Signed-off-by: Vishwanath Bhat <76242298+Vishwanath2001@users.noreply.github.com> --- production/helm/loki/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/production/helm/loki/CHANGELOG.md b/production/helm/loki/CHANGELOG.md index 9f46581caa284..9c93fedaf35f1 100644 --- a/production/helm/loki/CHANGELOG.md +++ b/production/helm/loki/CHANGELOG.md @@ -14,6 +14,7 @@ Entries should include a reference to the pull request that introduced the chang ## Unreleased - [BREAKING] The Loki UI has been moved to a Grafana Plugin. Enabling the UI in the helm chart will now only enable the APIs needed by the plugin, and will host them on the querier. The gateway will now forward all UI requests to the queriers. +- [CHANGE] Remove unused `storageClass` field from compactor persistence configuration. Storage class should be configured per-claim in the `claims` array instead.(https://github.com/grafana/loki/pull/19443) ## 6.42.0 From f772ad7d51837a053f66eb4d276ceba8874d68c4 Mon Sep 17 00:00:00 2001 From: Vishwanath Bhat Date: Thu, 16 Oct 2025 10:55:39 +0530 Subject: [PATCH 3/3] helm doc updated --- docs/sources/setup/install/helm/reference.md | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/docs/sources/setup/install/helm/reference.md b/docs/sources/setup/install/helm/reference.md index 209b6d6e754de..c7ed9f6eb6551 100644 --- a/docs/sources/setup/install/helm/reference.md +++ b/docs/sources/setup/install/helm/reference.md @@ -3036,8 +3036,6 @@ null ], "enableStatefulSetAutoDeletePVC": false, "enabled": false, - "size": "10Gi", - "storageClass": null, "whenDeleted": "Retain", "whenScaled": "Retain" }, @@ -3281,24 +3279,6 @@ false
 false
 
- - - - compactor.persistence.size - string - Size of persistent disk -
-"10Gi"
-
- - - - compactor.persistence.storageClass - string - Storage class to be used. If defined, storageClassName: . If set to "-", storageClassName: "", which disables dynamic provisioning. If empty or set to null, no storageClassName spec is set, choosing the default provisioner (gp2 on AWS, standard on GKE, AWS, and OpenStack). -
-null
-