Skip to content

fix(helm): Wrong context passed to loki.namespace helper from table manager servicemonitor #19544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
Merged

fix(helm): Wrong context passed to loki.namespace helper from table manager servicemonitor #19544

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9753e61
fix(helm): Wrong context passed to loki.namespace helper from table m…
jkroepke Oct 19, 2025
8fefb34
Merge branch 'main' into helm/fix-contex
jkroepke Oct 24, 2025
3ef1516
Merge branch 'main' into helm/fix-contex
Jayclifford345 Oct 28, 2025
44f5981
Merge branch 'main' into helm/fix-contex
Jayclifford345 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Entries should include a reference to the pull request that introduced the chang

## Unreleased

- [BUGFIX] Wrong context passed to loki.namespace helper from table manager servicemonitor. [#19461](https://github.com/grafana/loki/pull/19461)

## 6.44.0

- [DEPRECATION] The Loki Helm chart uses MinIO as an object store. MinIO will be removed from the Helm Charts in a future release. See [this issue](https://github.com/minio/minio/issues/21647) for more information. The Loki team is still investigating alternatives to replace MinIO.
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/table-manager/servicemonitor-table-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
{{- if .namespace }}
namespace: {{ .namespace }}
{{- else }}
namespace: {{ include "loki.namespace" . }}
namespace: {{ include "loki.namespace" $ }}
{{- end }}
{{- with .annotations }}
annotations:
Expand Down
Loading