Skip to content

Conversation

@jkroepke
Copy link
Contributor

What this PR does / why we need it:

See #18602 (comment) for context

Which issue(s) this PR fixes:
Fixes #18602

Special notes for your reviewer:

@QuentinBisson please review

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jkroepke jkroepke requested a review from a team as a code owner October 24, 2025 22:45
@jkroepke jkroepke changed the title feat(helm): nameOverride now passed through helps tpl function. feat(helm): nameOverride now passed through helm tpl function. Oct 24, 2025
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Copy link
Contributor

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loki Helm Chart does not include the release name in the kubernetes objects

3 participants