feat: add support for secrets in multihttp checks #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ugal
changed the title
d0ugal
changed the title
d0ugal
force-pushed
the
feature/pr3-multihttp-secrets
branch
4 times, most recently
from
d9f769e to
2304a80
Compare
Extract helper functions to reduce the nestif complexity from 17 to acceptable levels. - handleSecretVariables: processes secret variables in the buffer - handleRegularVariables: processes regular variables in remaining text - processRegularVariableMatches: processes regex matches for variables - writePlusIfNeeded: writes plus sign if builder has content - writeTextBeforeMatch: writes quoted text before regex match - writeQuotedText: writes text as quoted JavaScript string This refactoring maintains the same functionality while improving code readability and passing golangci-lint nestif complexity checks.
d0ugal
force-pushed
the
feature/pr3-multihttp-secrets
branch
from
212623a to
16e5979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1468 and adds support to multi http checks.
If #1468 hasn't merged it is best to look at the individual commits as its included.