converted missing value checks to call generic interface procedures for clarity

Author: scrasmussen

scm/src/scm_input.F90

@@ -4,9 +4,10 @@
 
 module scm_input
 
-use scm_kinds, only : sp, dp, qp
-use netcdf
+use data_qc, only: is_missing_value
+use scm_kinds, only: sp, dp, qp
 use scm_type_defs, only: character_length
+use netcdf
 
 implicit none
 
@@ -1185,15 +1186,13 @@ subroutine get_case_init_DEPHY(scm_state, scm_input)
   CHARACTER(LEN=nf90_max_name) :: tmpName
   CHARACTER(LEN=nf90_max_name) :: tmpUnits
   real(kind=sp), parameter :: p0 = 100000.0
-  real(kind=sp) :: exner, exner_inv, rho, elapsed_sec, missing_value_eps
+  real(kind=sp) :: exner, exner_inv, rho, elapsed_sec
   real(kind=dp) :: rinc(5)
   integer :: jdat(1:8), idat(1:8) !(yr, mon, day, t-zone, hr, min, sec, mil-sec)
   logical :: needed_for_lsm_ics, needed_for_model_ics, lev_in_altitude
 
   integer :: input_n_init_times, input_n_forcing_times, input_n_lev, input_n_snow, input_n_ice, input_n_soil, input_nvegcat, input_nsoilcat
 
-  missing_value_eps = missing_value + 0.01
-
   !> - Open the case input file found in the processed_case_input dir corresponding to the experiment name.
   call check(NF90_OPEN(trim(adjustl(scm_state%case_name))//'_SCM_driver.nc',nf90_nowrite,ncid),"nf90_open()")
 
@@ -2165,7 +2164,7 @@ subroutine get_case_init_DEPHY(scm_state, scm_input)
     end if
 
     !kinematic surface fluxes are specified (but may need to be converted)
-    if (maxval(input_force_wpthetap(:)) < missing_value_eps) then
+    if (is_missing_value(maxval(input_force_wpthetap(:)))) then
       write(*,*) 'The global attribute surfaceForcing in '//trim(adjustl(scm_state%case_name))//'.nc indicates that the variable wpthetap should be present, but it is missing. Stopping ...'
       error stop "The global attribute surfaceForcing indicates that the variable wpthetap should be present, but it is missing."
     else
@@ -2177,29 +2176,30 @@ subroutine get_case_init_DEPHY(scm_state, scm_input)
     end if
 
     !if mixing ratios are present, and not specific humidities, convert from mixing ratio to specific humidities
-    if ((maxval(input_force_wpqvp(:)) < missing_value_eps .and. &
-         maxval(input_force_wpqtp(:)) < missing_value_eps) .and. &
-        (maxval(input_force_wprvp(:)) > missing_value_eps .or. &
-         maxval(input_force_wprtp(:)) > missing_value_eps)) then
-       if (maxval(input_force_wprvp(:)) > missing_value_eps) then
+    if ((is_missing_value(maxval(input_force_wpqvp(:))) .and. &
+         is_missing_value(maxval(input_force_wpqtp(:)))) &
+         .and. &
+        (.not. is_missing_value(maxval(input_force_wprvp(:))) .or. &
+         .not. is_missing_value(maxval(input_force_wprtp(:))))) then
+       if (.not. is_missing_value(maxval(input_force_wprvp(:)))) then
          do i=1, input_n_forcing_times
            input_force_wpqvp(i) = input_force_wprvp(i)/&
               (1.0 + input_force_wprvp(i))
          end do
        end if
-       if (maxval(input_force_wprtp(:)) > missing_value_eps) then
+       if (.not. is_missing_value(maxval(input_force_wprtp(:)))) then
          do i=1, input_n_forcing_times
            input_force_wpqtp(i) = input_force_wprtp(i)/&
               (1.0 + input_force_wprtp(i))
          end do
        end if
     end if
 
-    if (maxval(input_force_wpqvp(:)) < missing_value_eps .and. maxval(input_force_wpqtp(:)) < missing_value_eps) then
+    if (is_missing_value(maxval(input_force_wpqvp(:))) .and. is_missing_value(maxval(input_force_wpqtp(:)))) then
       write(*,*) 'The global attribute surfaceForcing in '//trim(adjustl(scm_state%case_name))//'.nc indicates that the variable wpqvp, wpqtp, wprvp, or wprtp should be present, but all are missing. Stopping ...'
       error stop "The global attribute surfaceForcing indicates that the variable wpqvp, wpqtp, wprvp, or wprtp should be present, but all are missing."
     else
-      if (maxval(input_force_wpqvp(:)) > missing_value_eps) then !use wpqvp if available
+      if (.not. is_missing_value(maxval(input_force_wpqvp(:)))) then !use wpqvp if available
         scm_input%input_lh_flux_sfc_kin = input_force_wpqvp(:)
       else
         !surface total flux of water should just be vapor
@@ -2229,14 +2229,14 @@ subroutine get_case_init_DEPHY(scm_state, scm_input)
     end if
 
 
-    if (maxval(input_force_sfc_sens_flx(:)) < missing_value_eps) then
+    if (is_missing_value(maxval(input_force_sfc_sens_flx(:)))) then
       write(*,*) 'The global attribute surfaceForcing in '//trim(adjustl(scm_state%case_name))//'.nc indicates that the variable sfc_sens_flx should be present, but it is missing. Stopping ...'
       error stop "The global attribute surfaceForcing in indicates that the variable sfc_sens_flx should be present, but it is missing."
     else
       scm_input%input_sh_flux_sfc = input_force_sfc_sens_flx(:)
     end if
 
-    if (maxval(input_force_sfc_lat_flx(:)) < missing_value_eps) then
+    if (is_missing_value(maxval(input_force_sfc_lat_flx(:)))) then
       write(*,*) 'The global attribute surfaceForcing in '//trim(adjustl(scm_state%case_name))//'.nc indicates that the variable sfc_lat_flx should be present, but it is missing. Stopping ...'
       error stop "The global attribute surfaceForcing indicates that the variable sfc_lat_flx should be present, but it is missing."
     else