f: add CancelAgreementBy.ThirdParty

Author: matiasedgeandnode

packages/horizon/contracts/interfaces/IRecurringCollector.sol

@@ -24,7 +24,8 @@ interface IRecurringCollector is IAuthorizable, IPaymentsCollector {
     // @notice The party that can cancel an agreement
     enum CancelAgreementBy {
         ServiceProvider,
-        Payer
+        Payer,
+        ThirdParty
     }
 
     /// @notice A representation of a signed Recurring Collection Agreement (RCA)

packages/subgraph-service/contracts/SubgraphService.sol

@@ -235,7 +235,7 @@ contract SubgraphService is
             _allocations.get(allocationId).indexer == indexer,
             SubgraphServiceAllocationNotAuthorized(indexer, allocationId)
         );
-        _cancelAllocationIndexingAgreement(allocationId);
+        _cancelAllocationIndexingAgreement(allocationId, IRecurringCollector.CancelAgreementBy.ServiceProvider);
         _closeAllocation(allocationId, false);
         emit ServiceStopped(indexer, data);
     }
@@ -319,7 +319,7 @@ contract SubgraphService is
         Allocation.State memory allocation = _allocations.get(allocationId);
         require(allocation.isStale(maxPOIStaleness), SubgraphServiceCannotForceCloseAllocation(allocationId));
         require(!allocation.isAltruistic(), SubgraphServiceAllocationIsAltruistic(allocationId));
-        _cancelAllocationIndexingAgreement(allocationId);
+        _cancelAllocationIndexingAgreement(allocationId, IRecurringCollector.CancelAgreementBy.ThirdParty);
         _closeAllocation(allocationId, true);
     }
 
@@ -553,8 +553,11 @@ contract SubgraphService is
         return address(_graphStaking());
     }
 
-    function _cancelAllocationIndexingAgreement(address _allocationId) internal {
-        IndexingAgreement._getStorageManager().cancelForAllocation(_allocationId);
+    function _cancelAllocationIndexingAgreement(
+        address _allocationId,
+        IRecurringCollector.CancelAgreementBy _by
+    ) internal {
+        IndexingAgreement._getStorageManager().cancelForAllocation(_allocationId, _by);
     }
 
     /**

packages/subgraph-service/contracts/libraries/IndexingAgreement.sol

@@ -350,7 +350,11 @@ library IndexingAgreement {
         );
     }
 
-    function cancelForAllocation(StorageManager storage self, address _allocationId) external {
+    function cancelForAllocation(
+        StorageManager storage self,
+        address _allocationId,
+        IRecurringCollector.CancelAgreementBy by
+    ) external {
         bytes16 agreementId = self.allocationToActiveAgreementId[_allocationId];
         if (agreementId == bytes16(0)) {
             return;
@@ -361,13 +365,7 @@ library IndexingAgreement {
             return;
         }
 
-        _cancel(
-            self,
-            agreementId,
-            wrapper.agreement,
-            wrapper.collectorAgreement,
-            IRecurringCollector.CancelAgreementBy.ServiceProvider
-        );
+        _cancel(self, agreementId, wrapper.agreement, wrapper.collectorAgreement, by);
     }
 
     function cancelByPayer(StorageManager storage self, bytes16 agreementId) external {