Skip to content

Commit 5922122

Browse files
committed
fix more tests
1 parent d77d3d6 commit 5922122

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/graphiql/cypress/e2e/keyboard.cy.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ describe('GraphiQL keyboard interactions', () => {
1515
cy.get('@escapeHandler').should('have.been.called');
1616
});
1717

18-
// TODO recheck this test
1918
it('Does prevent the escape key from being handled outside the editor if closing the autocomplete dialog', () => {
2019
cy.visit('/');
2120
const mockFn = cy.stub().as('escapeHandler');
@@ -26,10 +25,10 @@ describe('GraphiQL keyboard interactions', () => {
2625
}
2726
});
2827
});
29-
3028
cy.get('.graphiql-query-editor textarea').type('{\n t', { force: true });
29+
// Wait autocomplete dialog to appear
30+
cy.get('.monaco-list').should('exist');
3131
cy.get('.graphiql-query-editor textarea').type('{esc}');
32-
3332
cy.get('@escapeHandler').should('not.have.been.called');
3433
});
3534
});

packages/graphiql/cypress/support/commands.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ Cypress.Commands.add(
170170
});
171171
expect(markers.length).to.be.greaterThan(0);
172172
cy.contains(text).trigger('mousemove');
173-
cy.contains(message, { timeout: 5_000 });
173+
cy.contains(message, { timeout: 6_000 });
174174
expect(markers[0].message).eq(message);
175175
const markerSeverity = {
176176
error: MarkerSeverity.Error,

0 commit comments

Comments
 (0)