test upstream LWT v1.3.6 change

Author: vincerubinetti

_cite/plugins/orcid.py

@@ -1,7 +1,7 @@
 import json
 from urllib.request import Request, urlopen
 from util import *
-from manubot.cite.handlers import prefix_to_handler as manubot_prefixes
+from manubot.cite.handlers import prefix_to_handler as manubot_citable
 
 
 def main(entry):
@@ -33,36 +33,66 @@ def query(_id):
     # list of sources to return
     sources = []
 
-    # go through response structure and pull out ids e.g. doi:1234/56789
+    # filter id by some criteria. return true to accept, false to reject.
+    def filter_id(_id):
+        # is id of certain "relationship" type
+        relationships = ["self", "version-of", "part-of"]
+        if not get_safe(_id, "external-id-relationship", "") in relationships:
+            return False
+
+        id_type = get_safe(_id, "external-id-type", "")
+
+        # is id of certain type
+        # types = ["doi"]
+        # if id_type not in types:
+        #     return False
+
+        # is id citable by manubot
+        if id_type not in manubot_citable:
+            return False
+
+        return True
+
+    # prefer some ids over others by some criteria. return lower number to prefer more.
+    def sort_id(_id):
+        types = [
+            "doi",
+            # "arxiv",
+            # "url",
+        ]
+        return index_of(types, get_safe(_id, "external-id-type", ""))
+
+    # go through each source
     for work in response:
-        # get list of ids
+        # list of ids in work
         ids = []
+
+        # use "work-summary" field instead of top-level "external-ids" to reflect author-selected preferred sources
         for summary in get_safe(work, "work-summary", []):
             ids = ids + get_safe(summary, "external-ids.external-id", [])
 
-        # find first id of particular "relationship" type
-        _id = next(
-            (
-                id
-                for id in ids
-                if get_safe(id, "external-id-relationship", "")
-                in ["self", "version-of", "part-of"]
-            ),
-            ids[0] if len(ids) > 0 else None,
-        )
-
-        if _id == None:
-            continue
-
-        # get id and id-type from response
+        # filter ids by criteria
+        ids = list(filter(filter_id, ids))
+        # sort ids by criteria
+        ids.sort(key=sort_id)
+
+        # pick first id
+        _id = ids[0] if len(ids) > 0 else None
+
+        # id parts
         id_type = get_safe(_id, "external-id-type", "")
         id_value = get_safe(_id, "external-id-value", "")
 
         # create source
-        source = {"id": f"{id_type}:{id_value}"}
+        source = {}
 
-        # if not an id type that Manubot can cite, keep citation details
-        if id_type not in manubot_prefixes:
+        # if id citable by manubot
+        if id_type and id_value and id_type in manubot_citable:
+            # id to cite with manubot
+            source = {"id": f"{id_type}:{id_value}"}
+
+        # if not citable by manubot, keep citation details from orcid
+        else:
             # get summaries
             summaries = get_safe(work, "work-summary", [])
 
@@ -107,3 +137,11 @@ def first(get_func):
         sources.append(source)
 
     return sources
+
+
+# index of, with fallback
+def index_of(_list, value):
+    try:
+        return _list.index(value)
+    except ValueError:
+        return float("inf")