test upstream LWT v1.3.6 change #158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
|
This looks generally fine. Not sure what's happening with that GECCO paper from 2008 showing up in 2024 - that was the main oddity I noticed. |
ORCID response for that paper[
{
"last-modified-date": {
"value": 1723057893590
},
"external-ids": {
"external-id": [
{
"external-id-type": "eid",
"external-id-value": "2-s2.0-57349142365",
"external-id-normalized": {
"value": "2-s2.0-57349142365",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
},
{
"external-id-type": "source-work-id",
"external-id-value": "0417180825475-140",
"external-id-normalized": {
"value": "0417180825475-140",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
}
]
},
"work-summary": [
{
"put-code": 19471920,
"created-date": {
"value": 1445449693701
},
"last-modified-date": {
"value": 1653410620906
},
"source": {
"source-orcid": null,
"source-client-id": {
"uri": "https://orcid.org/client/0000-0002-5982-8983",
"path": "0000-0002-5982-8983",
"host": "orcid.org"
},
"source-name": {
"value": "Scopus - Elsevier"
},
"assertion-origin-orcid": {
"uri": "https://orcid.org/0000-0001-8713-9213",
"path": "0000-0001-8713-9213",
"host": "orcid.org"
},
"assertion-origin-client-id": null,
"assertion-origin-name": {
"value": "Casey Greene"
}
},
"title": {
"title": {
"value": "Using expert knowledge in initialization for genome-wide analysis of epistasis using genetic programming"
},
"subtitle": null,
"translated-title": null
},
"external-ids": {
"external-id": [
{
"external-id-type": "eid",
"external-id-value": "2-s2.0-57349142365",
"external-id-normalized": {
"value": "2-s2.0-57349142365",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
}
]
},
"url": {
"value": "http://www.scopus.com/inward/record.url?eid=2-s2.0-57349142365&partnerID=MN8TOARS"
},
"type": "conference-paper",
"publication-date": {
"year": {
"value": "2008"
},
"month": null,
"day": null
},
"journal-title": {
"value": "GECCO'08: Proceedings of the 10th Annual Conference on Genetic and Evolutionary Computation 2008"
},
"visibility": "public",
"path": "/0000-0001-8713-9213/work/19471920",
"display-index": "0"
},
{
"put-code": 43716410,
"created-date": {
"value": 1523967926327
},
"last-modified-date": {
"value": 1653598065810
},
"source": {
"source-orcid": null,
"source-client-id": {
"uri": "https://orcid.org/client/0000-0003-1377-5676",
"path": "0000-0003-1377-5676",
"host": "orcid.org"
},
"source-name": {
"value": "ResearcherID"
},
"assertion-origin-orcid": {
"uri": "https://orcid.org/0000-0001-8713-9213",
"path": "0000-0001-8713-9213",
"host": "orcid.org"
},
"assertion-origin-client-id": null,
"assertion-origin-name": {
"value": "Casey Greene"
}
},
"title": {
"title": {
"value": "Using expert knowledge in initialization for genome-wide analysis of epistasis using genetic programming"
},
"subtitle": null,
"translated-title": null
},
"external-ids": {
"external-id": [
{
"external-id-type": "source-work-id",
"external-id-value": "0417180825475-140",
"external-id-normalized": {
"value": "0417180825475-140",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
}
]
},
"url": {
"value": "http://www.scopus.com/inward/record.url?eid=2-s2.0-57349142365&partnerID=MN8TOARS"
},
"type": "conference-paper",
"publication-date": {
"year": {
"value": "2008"
},
"month": null,
"day": null
},
"journal-title": {
"value": "GECCO’08: Proceedings of the 10th Annual Conference on Genetic and Evolutionary Computation 2008"
},
"visibility": "public",
"path": "/0000-0001-8713-9213/work/43716410",
"display-index": "0"
},
{
"put-code": 165116049,
"created-date": {
"value": 1723057893590
},
"last-modified-date": {
"value": 1723057893590
},
"source": {
"source-orcid": {
"uri": "https://orcid.org/0000-0001-8713-9213",
"path": "0000-0001-8713-9213",
"host": "orcid.org"
},
"source-client-id": null,
"source-name": {
"value": "Casey Greene"
},
"assertion-origin-orcid": null,
"assertion-origin-client-id": null,
"assertion-origin-name": null
},
"title": {
"title": {
"value": "Using expert knowledge in initialization for genome-wide analysis of epistasis using genetic programming"
},
"subtitle": null,
"translated-title": null
},
"external-ids": {
"external-id": [
{
"external-id-type": "source-work-id",
"external-id-value": "0417180825475-140",
"external-id-normalized": {
"value": "0417180825475-140",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
},
{
"external-id-type": "eid",
"external-id-value": "2-s2.0-57349142365",
"external-id-normalized": {
"value": "2-s2.0-57349142365",
"transient": true
},
"external-id-normalized-error": null,
"external-id-url": null,
"external-id-relationship": "self"
}
]
},
"url": {
"value": "http://www.scopus.com/inward/record.url?eid=2-s2.0-57349142365&partnerID=MN8TOARS"
},
"type": "conference-paper",
"publication-date": {
"year": {
"value": "2008"
},
"month": null,
"day": null
},
"journal-title": {
"value": "GECCO’08: Proceedings of the 10th Annual Conference on Genetic and Evolutionary Computation 2008"
},
"visibility": "public",
"path": "/0000-0001-8713-9213/work/165116049",
"display-index": "-1"
}
]
}
]So, for that paper, there aren't any Manubot-citable ID types, and thus we fall back to keeping the citation details directly from ORCID, which list a last modified date of I think we've discussed previously whether "last modifed" or "created" date should be preferred, and I think ultimately it will vary from paper to paper but we should default to "last modified" (current behavior). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See greenelab/lab-website-template#330 and greenelab/lab-website-template#327
Testing to see how the new
orcid.pyplugin logic affects Casey's ORCID sources.