v1.3.5 (#324)

Closes #321 
Closes #320 
Closes #322
Supersedes #323  

Co-authored by @d33bs 

FOR THE TEMPLATE MAINTAINER(S)

New template version checklist:

- [x] I have updated CITATION and CHANGELOG as appropriate.
- [x] I have updated lab-website-template-docs as appropriate.
- [x] I have checked the testbed as appropriate.

Author: vincerubinetti

.github/workflows/build-preview.yaml

@@ -42,22 +42,14 @@ jobs:
         id: pages
         uses: actions/configure-pages@v4
 
-      - uses: jwalton/gh-find-current-pr@master
-        if: github.event.action != 'closed'
-        id: pr
-        with:
-          state: all
-
       - name: SSH debug
         if: runner.debug == '1'
         uses: mxschmitt/action-tmate@v3
 
       - name: Build preview version of site
         if: github.event.action != 'closed'
         run: |
-          JEKYLL_ENV=production bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path || '' }}/${{ env.PREVIEWS_FOLDER }}/pr-${{ env.pr }}"
-        env:
-          pr: ${{ steps.pr.outputs.pr }}
+          JEKYLL_ENV=production bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path || '' }}/${{ env.PREVIEWS_FOLDER }}/pr-${{ github.event.number }}"
 
       - name: Commit preview to Pages branch
         uses: rossjrw/pr-preview-action@v1.4.7

.github/workflows/first-time-setup.yaml

@@ -34,7 +34,7 @@ jobs:
 
       # clean slate, as if starting from orphan branch
       - name: Clear Pages branch
-        run: rm -rf * .github .docker .gitignore
+        run: rm -rf ./* .github .docker .gitignore
 
       # prevent GitHub from running Jekyll a second time after build
       - name: Make .nojekyll file
@@ -70,8 +70,8 @@ jobs:
         run: |
           user="${{ github.repository_owner }}"
           description="An engaging 1-3 sentence description of your lab."
-          printf "\nUSER=${user}" >> $GITHUB_ENV
-          printf "\nDESCRIPTION=${description}" >> $GITHUB_ENV
+          printf "\nUSER=%s" "$user" >> "$GITHUB_ENV"
+          printf "\nDESCRIPTION=%s" "$description" >> "$GITHUB_ENV"
 
       - name: Personalize readme for user
         run: |
@@ -80,12 +80,12 @@ jobs:
             ![on-pull-request](../../actions/workflows/on-pull-request.yaml/badge.svg)
             ![on-schedule](../../actions/workflows/on-schedule.yaml/badge.svg)
 
-            # ${{ env.USER }}'s Website
+            # %s's Website
 
             Visit **[website url](#)** 🚀
 
             _Built with [Lab Website Template](https://greene-lab.gitbook.io/lab-website-template-docs)_
-          " > README.md
+          " "${{ env.USER }}" > README.md 
 
       - name: Personalize Jekyll config for user
         uses: actions/github-script@v7
@@ -119,4 +119,4 @@ jobs:
       - name: Commit changed files
         uses: stefanzweifel/git-auto-commit-action@v5
         with:
-          commit_message: "Setup repo"
+          commit_message: "Set up repo"

.github/workflows/update-citations.yaml

@@ -38,7 +38,7 @@ jobs:
           repository: ${{ github.event.pull_request.head.repo.full_name }}
           ref: ${{ github.head_ref }}
 
-      - name: Setup Python
+      - name: Set up Python
         if: github.event.action != 'closed'
         uses: actions/setup-python@v5
         with:

.github/workflows/versioning.yaml

@@ -22,6 +22,7 @@ jobs:
     steps:
       - name: Debug dump
         uses: crazy-max/ghaction-dump-context@v2
+
       - if: runner.debug == '1'
         uses: mxschmitt/action-tmate@v3
 
@@ -36,6 +37,13 @@ jobs:
         with:
           path: pr
 
+      - name: Lint actions
+        run: |
+          bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
+          ./actionlint -color
+        shell: bash
+        working-directory: pr
+
       - name: Install packages
         run: npm install yaml semver
 

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 Reference: common-changelog.org
 
+## 1.3.5 - 2025-05-12
+
+###
+
+- Fix workflow bug where PR previews on GitHub Actions have broken styles/links/etc. 
+- Fix tags component relative link bug
+- Make Actions workflows a bit more robust
+
 ## 1.3.4 - 2025-02-03
 
 ### Changed

CITATION.cff

@@ -1,8 +1,8 @@
 # citation metadata for the template itself
 
 title: "Lab Website Template"
-version: 1.3.4
-date-released: 2025-02-03
+version: 1.3.5
+date-released: 2025-05-12
 url: "https://github.com/greenelab/lab-website-template"
 authors:
   - family-names: "Rubinetti"

_includes/tags.html

@@ -16,13 +16,10 @@
     {% if include.repo %}
       data-repo="{{ include.repo | xml_escape }}"
     {% endif %}
-    {% if link %}
-      data-link="{{ link | relative_url | xml_escape }}"
-    {% endif %}
   >
     {% for tag in tags %}
       <a
-        href="{{ link }}?search=&quot;tag: {{ tag }}&quot;"
+        href="{{ link | relative_url }}?search=&quot;tag: {{ tag }}&quot;"
         class="tag"
         data-tooltip="Show items with the tag &quot;{{ tag }}&quot;"
       >