Skip to content

Fix multiple daily scrums issue #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix multiple daily scrums issue #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3211ec5
fix issues.totalCount problem
emma2207 May 1, 2025
d923f12
comments
emma2207 May 1, 2025
cda74f4
Merge branch 'master' into multiple_issues
cgreene May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion upkeep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,16 @@ def get_upcoming_workdays(workdays_ahead: int = 2) -> typing.Iterator[datetime.d
# to help ensure the most recent existing e-scrum issue is included even when other
# non e-scrum issues exist
issues = repo.get_issues(state='all', sort='number', direction='desc')
issues = issues[:min(10 + args.workdays_ahead, issues.totalCount)]
# If totalCount is working properly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding a link to the PR with the bug description or describing it in the comment

if issues.totalCount > 0:
issues = issues[:min(10 + args.workdays_ahead, issues.totalCount)]
else:
# Try reducing the number of issues
try:
issues = issues[:(10 + args.workdays_ahead)]
# But if that's not possible, just continue
except:
pass
Comment on lines +184 to +186
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know more about the error that could occur (i.e. except a specific error) and why it happens?

date_issue_pairs = [(issue_title_to_date(issue.title), issue) for issue in issues]
# Filter issues that are not scrum entries
filtered_date_issue_pairs = [(date, issue) for date, issue in date_issue_pairs if date]
Expand Down
2 changes: 1 addition & 1 deletion uptime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
It has been 885 days since I last had to tinker with the scrum bot.
It has been 0 days since I last had to tinker with the scrum bot.