Skip to content

Issue 23: Display public IP address #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Issue 23: Display public IP address #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from prompt_toolkit import print_formatted_text, HTML
from websockets.exceptions import ConnectionClosedError
from utils.helper_display import HelperDisplay
from requests import get
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests is quite a heavy module to import for task as small as this. Also, we cannot just assume that the users have curl or wget binaries installed on their distribution which makes it a difficult point to discuss about.



USERS = {}
Expand All @@ -28,6 +29,10 @@ def getallus(chatroom):
return userlist


def ipaddress():
return get('https://api64.ipify.org').text
Comment on lines +32 to +33
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a great job in retrieving an IPv6 address as evidenced in the screenshot I have attached just below.

image

But when it comes to IPv4, it still ends up fetching the IPv6 address.

image



async def notify_mesej(message):
if USERS: await asyncio.wait([user.send(message) for user in USERS])

Expand All @@ -40,11 +45,13 @@ def chk_username_presence(mesg_json):
else:
return False


async def send_chatroommembers_list(websoc):
chatroom_id = USERS[websoc][1]
users_list = "SNCTRYZERO" + sepr + "USERSLIST" + sepr + str(getallus(chatroom_id)) + sepr + chatroom_id
await websoc.send(users_list)


async def chatroom(websocket, path):
if not websocket in USERS:
USERS[websocket] = ""
Expand Down Expand Up @@ -107,9 +114,10 @@ def mainfunc(chatport, netprotc):
elif netprotc == "ipprotv4":
print_formatted_text(HTML("[" + obtntime() + "] " + "<b>SNCTRYZERO</b> > <green>IP version : 4</green>"))
netpdata = "0.0.0.0"
print_formatted_text(HTML("[" + obtntime() + "] " + "<b>SNCTRYZERO</b> > <green>IP address : " + ipaddress() + "</green>"))
servenow(netpdata, chatport)
except OSError:
print_formatted_text(HTML("[" + obtntime() + "] " + "<b>SNCTRYZERO</b> > <red><b>The server could not be started up</b></red>"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch with the corrected message. 😉

print_formatted_text(HTML("[" + obtntime() + "] " + "<b>SNCTRYZERO</b> > <red><b>The server could not be started</b></red>"))


if __name__ == "__main__":
Expand Down