Skip to content

[BUG] More duration issues #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andrew-J-Larson opened this issue May 22, 2020 · 2 comments
Closed

[BUG] More duration issues #62

Andrew-J-Larson opened this issue May 22, 2020 · 2 comments

Comments

@Andrew-J-Larson
Copy link

Andrew-J-Larson commented May 22, 2020

This file, Death Waltz.mid, should show up of a duration around 3:32 (about 212 seconds), yet loads with a duration of about 2,077‬ seconds...

Hopefully it's not too hard too fix either.

@grimmdude
Copy link
Owner

Hi @TheAlienDrew,

I think the issue here is that there's a "Set Tempo" event for 20 at the beginning of the file and the player is using that as the default. So the song duration is being calculated based on that, hence the very long duration. I just pushed a change so that the player will actually change tempo when a tempo event is triggered which I think should also address the issue you mentioned in #61. Let me know your thoughts on that.

Ideally, the song duration should calculate with all tempo changes factored in but currently it's only being calculated based on the current tempo. Will try to address that shortly.

-Garrett

@Andrew-J-Larson
Copy link
Author

Andrew-J-Larson commented May 25, 2020

Yes that fixed the issue, and it fixed duration time in #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants