Fixed #7839: Custom Fields on Print Assigned #17426
Conversation
401 error on js tweaks
not saved on new field creation yet tho
snipe
changed the title
|
This looks good so far - one thing I'm worried about is that I don't think we're checking to see if a custom field that's been marked as include-able in the print view should be able to see the values of encrypted custom fields. |
That makes sense. I think you are right, and I'll look into that. |
|
So it does look like I already included to check for encrypted fields on the print out. |
| paginationVAlign: 'both', | ||
| queryParams: function (params) { | ||
| var newParams = {}; | ||
| for(var i in params) { |
|
I'm not sure why we need a migration here tbh. If we have the column-select already, can we not just add it to there? |
the migration is adding it as a checkbox option so people can choose to include it on the print out. |
|
No, I got that part, but the column selector would let you show/hide on the page as well, and we already have a column selector there |
|
ah, i see what you are saying. okok |
|
Okay, so, I don't think we'd want to do that. My method allows the items to be individually selected, and then presents that to you in the custom fields table. I feel this is better for organization and being able to reference what is and is not shown on the report easier than using the column selector. If we removed the migration and went for the dropdown column selector, that dropdown can get REALLY gnarly REALLY quickly for any one who has many custom fields. Additionally, with my method, you can choose if you want to place it on that print out when you create the custom field. |
2 participants
Custom Fields have been added to the print all assigned sheet.
Custom fields to display on the print out sheet can be selected on the custom fields page.
Fixes #7839: